On Fri, Oct 01, 2010 at 05:14:04PM +0100, Toby Gray wrote: > Yes. Sorry, I missed out that rather essential bit of information :) > Option #4 fixes both the time out issue on some machines (which was > previously fixed by SET INTERFACE) and the usb-storage issue (which is > caused by SET INTERFACE). > > I'd pick 4, with lots of comments in the code to explain why. :-) > I was hoping you'd say go for 4. I've submitted it to my github branch > as c869133cae5f3b27b321. I've tested it with a range of OS v4 and OS v5 > devices inside and outside of a VM and it works nicely.
It's the best of both worlds, then. Merged with gratitude. :-) And thanks for the large comment... very helpful for future maintenance. > I'm half tempted to add in option 2 as well, just to be sure that Barry > tries as hard as possible to work, even if it causes some issues with > usb-storage. What do you think? Option 2 was: > >> 2) Change the probing code in src/probe.cc so that it tries probing the > >> end points without a call to SET INTERFACE and then, if those probes > >> fail, calls SET INTERFACE and probes again. I think it's probably best > >> to probe all the end points and then call SET INTERFACE, rather than > >> doing a probe, SET INTERFACE, and then a re-probe for each end point in > >> turn. This would still have the usb-storage issue, but only for users > >> where calling SET INTERFACE is necessary. Currently there is no call to usb_set_altinterface() in Barry anymore. As I recall, that was useful for FreeBSD and Mac OSX, although it looks like you've tested on those platforms already with success. I'd say go for it. If the common case almost always works, then there's no speed penalty during startup anyway. Thanks! - Chris ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ Barry-devel mailing list Barry-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/barry-devel
