Hello,

changing only the font when editing tags wasn't working
The signal textChanged is silently ignored on a QFontComboBox.
I've replaced it with currentFontChanged(const QFont&).

By the way, defaulting fonts family to the index(0) in Tag Editing -
when the note editor is correctly initialized to the System Settings
value seems quite inconsistent for me.

Maybe this behavior should be corrected ?

Olivier Rollet
diff --git a/src/tagsedit.cpp b/src/tagsedit.cpp
index 17b231e..a55784d 100644
--- a/src/tagsedit.cpp
+++ b/src/tagsedit.cpp
@@ -618,7 +618,8 @@ TagsEditDialog::TagsEditDialog(QWidget *parent, State *stateToEdit, bool addNewT
     connect(m_italic,          SIGNAL(toggled(bool)),                      this, SLOT(modified()));
     connect(m_strike,          SIGNAL(toggled(bool)),                      this, SLOT(modified()));
     connect(m_textColor,       SIGNAL(activated(const QColor&)),             this, SLOT(modified()));
-    connect(m_font,            SIGNAL(textChanged(const QString&)),        this, SLOT(modified()));
+    //connect(m_font,            SIGNAL(textChanged(const QString&)),        this, SLOT(modified()));
+    connect(m_font,            SIGNAL(currentFontChanged(const QFont&)),        this, SLOT(modified()));
     connect(m_fontSize,        SIGNAL(textChanged(const QString&)),        this, SLOT(modified()));
     connect(m_textEquivalent,  SIGNAL(textChanged(const QString&)),        this, SLOT(modified()));
     connect(m_onEveryLines,    SIGNAL(stateChanged(int)),                  this, SLOT(modified()));
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Basket-devel mailing list
Basket-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/basket-devel

Reply via email to