Hi Randy,
Randy Jeune <[EMAIL PROTECTED]> wrote on 12/19/2005 06:25:07 PM:
> [PATCH] Found correctness bugs in implementation of Batik 1.6
>
> Hello, my name is Vladimir Jeune. I was interested in your project and
> decided to try contributing to an Open Source project. I ran a program
> called Findbugs on the Batik code and found some correctness
> bugs in the implementation of Batik 1.6.
Thanks if you are serious it is helpful to complete a Contributors
License Agreement. The items below are small enough that I'm not
worried about this for this contribution but I draw the line for
needing a CLA on file fairly low.
> There were a couple places where Object.equals() was overridden but not
> Object.hashcode().
It's much better to provide a 'real' value than some fixed value.
> There were also some calls to new Boolean(boolean) which is not
recommended
> since valueof(boolean) gives better space and time performance.
These aren't very performance intensive areas and valueOf(boolean)
doesn't exist in jdk 1.3 (our current baseline runtime).
> I hope that this was useful.
Thanks for taking the time to contribute.
BTW I didn't use the patches (for various reasons) but
the best way to generate a patch is straight from SVN. If
you use the command line tools 'svn diff' will do it, Tortoise
also has an option to generate a patch file. It would have
been a fair amount of work to use the patch files as provided.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
