Hi Thomas.

Thomas DeWeese:
>      I've noticed that the anim code doesn't currently compile under JDK 
> 1.3.

I probably should try compiling with 1.3 more often!

>      I've fixed a couple of the problems but there are two major issues:
> 
>         1) The use of LinkedHashSet in the 
> batik.anim.timing.TimeContainer.
>              This is tricky since we want the 'quick' removal.  However I 
> think
>              we probably need to just switch to a simple LinkedList 
> perhaps with
>              a matching set (to avoid duplicate adds, I'm not sure if this 
> can happen).

Yeah, I think with normal operation that TimedElements won’t ever be
added more than once.  I’d be happy with it just being a LinkedList.

>         2) The use of 'RuntimeException' with the 'cause' Throwable.  This 
> isn't
>                      available in 1.3.  We could subclass or just use the 
> 'causes' message
>             to fill the RuntimeException.

Those in JSVGViewerFrame?  I guess those exceptions should never be
thrown in normal operation anyway.  In general I would prefer to keep
the cause, but for these I don’t really mind; using the message should
be fine.

-- 
Cameron McCormack, http://mcc.id.au/
        xmpp:[EMAIL PROTECTED]  ▪  ICQ 26955922  ▪  MSN [EMAIL PROTECTED]

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to