https://issues.apache.org/bugzilla/show_bug.cgi?id=45296
Helder Magalhães <[EMAIL PROTECTED]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--- Comment #2 from Helder Magalhães <[EMAIL PROTECTED]> 2008-11-21 09:36:08
PST ---
I've analyzed the patch and, from the link [1], the only things that is not
clear to me is if versions are backwards compatible, that is, if a version 2
font includes all version 1 information. The documentation says "only version X
tables", something which confuses (me) a bit.
So, my doubt is if:
+ if (version >= 1) {
Should be:
+ if (version == 1) {
Naturally, the same poses for the version 2 check. Apart from this, this seems
good to me. A (commented) link to the documentation within the patch would also
sound reasonable to further support the version-specific handling. :-)
[1]
http://freetype.sourceforge.net/freetype2/docs/reference/ft2-truetype_tables.html#TT_OS2
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
