https://issues.apache.org/bugzilla/show_bug.cgi?id=47359
--- Comment #11 from Helder Magalhães <[email protected]> 2009-06-16 11:20:13 PST --- (In reply to comment #8) > > Missing space before "asb" in: [code snippet] > > Missing space before "elementAttributes" in: [code snippet] > I've addressed those issues in the 2nd submitted patch. Apparently not those two items. ;-) > + for(int k = 0; k < values.size(); k++) > + { > + Object baselineValue = values.get(k); Could/should the "Object" variable be moved to outside the cycle? Although the nesting will probably never be more than one level... > + //for the child of the element Seems that a superfluous (indenting) space slipped into that line. ;-) > handleNestedBaselineShift( Map, Map ) is called from one location only and a > few lines before the call, elementsAttributes is set to new HashMap(). > I assume it is safe not to check elementAttributes within that method. Sounds reasonable. :-) > I've attached test file for animation and scripting as well for the review. Cool, I noticed the attachments but didn't have the chance to test them yet. Nevertheless, you didn't state whether the patch properly handled those situations (although you working suggests so). I'd say that, even without the minor formatting stuff integrated, the patch is ready for a deeper review from someone with a deeper knowledge on Batik's internals (assuming that the animation cases are being properly handled, as guessed in the previous paragraph). ;-) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
