https://issues.apache.org/bugzilla/show_bug.cgi?id=44531





--- Comment #1 from Helder Magalhães <[email protected]>  2009-07-19 
15:57:36 PST ---
Created an attachment (id=24006)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24006)
Patch from proposal

(In reply to comment #0)
> Attribute underline-position of element <font-face> seems to get negatived 
> (-).
> Compared to attributes overline-position and strikethrough-position, this
> appears as unexpected. Apparently none of the SVG test fonts use
> underline-position and the default value looks fine.

After investigating a bit, I've found that
"samples/tests/spec/fonts/fontDecorations.svg" does use underline in a SVG font
and, although no specific value is given to the "underline-position" property,
just using underline seems to be enough (so I'd argue on the default value
looking fine statement). ;-)


> See getLineMetrics(int,int) in SVGGVTFont.java for the assignment to ulOffset
> without - in front of variable scale.

The attached patch does exactly that. :-)  Fixes the attached test case and
also improves look in "fontDecorations.svg". ;-)


> It might also be nice if stroke-width of underline would scale with font-size.

By taking a look at the source code and performing a quick test, it seems that
it's already being done. Thing is the test case attached to this bug report
uses a zero-width stroke, which intuitively would not scale (but I haven't
double checked the specification regarding this; I'm not even sure if
zero-width strokes should render...).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to