https://issues.apache.org/bugzilla/show_bug.cgi?id=51765

Mario <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29267|bug51765_incorrect-text-dec |[INCORRECT PATCH PLEASE
           filename|orations-in-flowing-text.pa |REMOVE]
                   |tch                         |bug51765_incorrect-text-dec
                   |                            |orations-in-flowing-text.pa
                   |                            |tch
  Attachment #29267|0                           |1
        is obsolete|                            |

--- Comment #5 from Mario <[email protected]> ---
Comment on attachment 29267
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29267
Fixes the incorrect positioning of underline, overline and line-through in
flowing text tags

This patch does not fix everything regarding the positioning of the text
decorations. Especially I later noticed that the line-through text decoration
was not positioned correctly. That was because I used the max y position of the
geometric bounds of the glyph vector. When the text descends beyond the
baseline (as it does with characters like 'g', 'j', etc.) the line-through
appeared still too low.
The patch marked as [CORRECT] fixes this by not using the max y position of the
geometric bounds of the glyph vector, but employing the y position of the first
glyph in the glyph vector. That is basically the baseline of the glyph vector
as I figure it. Results in tests confirm that (see patch test case svg).

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to