[
https://issues.apache.org/jira/browse/BATIK-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Hendriks updated BATIK-1386:
-----------------------------------
Description:
In BATIK-1363, ignoring of Inkscape properties when scanning/parsing CSS was
added through commit
[https://github.com/apache/xmlgraphics-batik/commit/f6610f7f1cd0ca97874222d787c62e69a8c33128].
Even a test was added in
{{batik-css/src/test/java/org/apache/batik/css/parser/ParserTestCase.java}}
that shows it works for "{{{}a:b;-inkscape-font-specification:'Calibri,
Normal';c:d{}}}" in that property "{{{}c{}}}" gets processed as well. However,
if the "{{{}a:b;{}}}" prefix is removed, then the test fails, as the Inkscape
property and everything that follows it are then wrongly ignored.
It seems that if an Inkscape property is preceded by "{{{};{}}}", then it
works. If it is the first property, then it doesn't work, and the Inkscape
property and everything that follows it are completely ignored.
I still think this should be fixed in general, for all properties starting with
a "\-", as per BATIK-1368, as all properties starting with a "\-" are valid
according to the CSS standard. However, I currently only need it for Inkscape
properties, so fixing it for that is sufficient. Hence, I create this separate
issue.
was:
In BATIK-1363, ignoring of Inkscape properties when scanning/parsing CSS was
added through commit
[https://github.com/apache/xmlgraphics-batik/commit/f6610f7f1cd0ca97874222d787c62e69a8c33128].
Even a test was added in
{{batik-css/src/test/java/org/apache/batik/css/parser/ParserTestCase.java}}
that shows it works for "{{{}a:b;-inkscape-font-specification:'Calibri,
Normal';c:d{}}}" in that property "{{{}c{}}}" gets processed as well. However,
if the "{{{}a:b;{}}}" prefix is removed, then the test fails, as the Inkscape
property and everything that follows it are then wrongly ignored.
It seems that if an Inkscape property is preceded by "{{{};{}}}", then it
works. If it is the first property, then it doesn't work, and the Inkscape
property and everything that follows it are completely ignored.
I still think this should be fixed in general, for all properties starting with
a "-", as per BATIK-1368, as all properties starting with a "-" are valid
according to the CSS standard. However, I currently only need it for Inkscape
properties, so fixing it for that is sufficient. Hence, I create this separate
issue.
> Ignoring Inkscape properties doesn't work if it is the first property
> ---------------------------------------------------------------------
>
> Key: BATIK-1386
> URL: https://issues.apache.org/jira/browse/BATIK-1386
> Project: Batik
> Issue Type: Bug
> Affects Versions: 1.19
> Reporter: Dennis Hendriks
> Priority: Major
>
> In BATIK-1363, ignoring of Inkscape properties when scanning/parsing CSS was
> added through commit
> [https://github.com/apache/xmlgraphics-batik/commit/f6610f7f1cd0ca97874222d787c62e69a8c33128].
> Even a test was added in
> {{batik-css/src/test/java/org/apache/batik/css/parser/ParserTestCase.java}}
> that shows it works for "{{{}a:b;-inkscape-font-specification:'Calibri,
> Normal';c:d{}}}" in that property "{{{}c{}}}" gets processed as well.
> However, if the "{{{}a:b;{}}}" prefix is removed, then the test fails, as the
> Inkscape property and everything that follows it are then wrongly ignored.
> It seems that if an Inkscape property is preceded by "{{{};{}}}", then it
> works. If it is the first property, then it doesn't work, and the Inkscape
> property and everything that follows it are completely ignored.
> I still think this should be fixed in general, for all properties starting
> with a "\-", as per BATIK-1368, as all properties starting with a "\-" are
> valid according to the CSS standard. However, I currently only need it for
> Inkscape properties, so fixing it for that is sufficient. Hence, I create
> this separate issue.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
