Well done, Karl, you broke bbdb!

------- start of forwarded message (RFC 934 encapsulation) -------
From: Vapor User <>
To: [EMAIL PROTECTED]
Date: Mon, 14 Aug 1995 20:48:33 -0500
Subject: did you know that, under Linux

        you can have a user named  , (but funny things may happen when
that user sends mail)?

        From now on, I'm doing all my work as  .

Love,
 
------- end -------

This broke by passing nil to string-match.  Here's my patch.
------- begin context diff -------
*** orig-bbdb-vm.el     Tue Aug 15 11:21:58 1995
--- bbdb-vm.el  Tue Aug 15 11:33:05 1995
***************
*** 59,69 ****
                (narrow-to-region (vm-start-of msg) (vm-end-of msg))
                (let ((from (mail-fetch-field "from")))
                  (if (or (null from)
!                         (string-match (bbdb-user-mail-names)
                            ;; mail-strip-quoted-names is too broken!
                            ;;(mail-strip-quoted-names from)
-                           (car (cdr (mail-extract-address-components
-                                      from)))))
                      ;; if logged in user sent this, use recipients.
                      (setq from (or (mail-fetch-field "to") from)))
                  (if from
--- 59,74 ----
                (narrow-to-region (vm-start-of msg) (vm-end-of msg))
                (let ((from (mail-fetch-field "from")))
                  (if (or (null from)
!                         (let
!                             ((addrbit
!                               (car
!                                (cdr
!                                 (mail-extract-address-components from)))))
!                           (and addrbit
!                                (string-match (bbdb-user-mail-names)
!                                              addrbit))))
                            ;; mail-strip-quoted-names is too broken!
                            ;;(mail-strip-quoted-names from)
                      ;; if logged in user sent this, use recipients.
                      (setq from (or (mail-fetch-field "to") from)))
                  (if from
------- ffid txetnoc nigeb -------

(Just joined info-bbdb; my apple logies if this has already been found
and nailed.)

 --adrian.
http://wuh.three.serpentine.com/u/aecolley/

Reply via email to