I've got bbdb-use-pop-up set to nil and bbdb-pop-up-elided-display set
to t. Starting with my upgrade to 2.32, this combination shows me the
pop-up window, which is wrong. The patch below fixes.
The identation in the function wasn't right. The whitespace changes
for the correct indentation obscure the actual patch itself, so I've
included two versions of the patch, one with -wc and one with -u.
Here's the actual change made.
*** bbdb-gnus.el Sat Feb 24 03:00:59 2001
--- bbdb-gnus.el Sat Aug 4 15:22:15 2001
***************
*** 135,142 ****
gnus-summary-buffer
gnus-Subject-buffer)))
(select-window w)))))
! (set-buffer b)))
! (if record (bbdb-display-records (list record)))
record))
;;
--- 135,142 ----
gnus-summary-buffer
gnus-Subject-buffer)))
(select-window w)))))
! (set-buffer b))
! (if record (bbdb-display-records (list record))))
record))
;;
Here's the change to apply, assuming the above is correct. (The when
and let are at the same indentation level, even though the latter is
contained in the former.) I just let C-M-q do its magic.
--- bbdb-gnus.el.z Sat Feb 24 03:00:59 2001
+++ bbdb-gnus.el Sat Aug 4 15:22:15 2001
@@ -112,31 +112,31 @@
(bbdb-electric-p nil))
(when bbdb-use-pop-up
- (let ((bbdb-elided-display (bbdb-pop-up-elided-display))
- (b (current-buffer)))
- ;; display the bbdb buffer iff there is a record for this article.
+ (let ((bbdb-elided-display (bbdb-pop-up-elided-display))
+ (b (current-buffer)))
+ ;; display the bbdb buffer iff there is a record for this article.
(if record
- (bbdb-pop-up-bbdb-buffer
+ (bbdb-pop-up-bbdb-buffer
(lambda (w)
- (let ((b (current-buffer)))
- (set-buffer (window-buffer w))
- (prog1 (or (eq major-mode 'gnus-Article-mode)
- (eq major-mode 'gnus-article-mode))
+ (let ((b (current-buffer)))
+ (set-buffer (window-buffer w))
+ (prog1 (or (eq major-mode 'gnus-Article-mode)
+ (eq major-mode 'gnus-article-mode))
(set-buffer b)))))
- (or bbdb-inside-electric-display
- (not (get-buffer-window bbdb-buffer-name))
- (let (w)
- (delete-other-windows)
- (if (assq 'article gnus-buffer-configuration)
- (gnus-configure-windows 'article)
- (gnus-configure-windows 'SelectArticle))
- (if (setq w (get-buffer-window
- (if (boundp 'gnus-summary-buffer)
- gnus-summary-buffer
- gnus-Subject-buffer)))
- (select-window w)))))
- (set-buffer b)))
- (if record (bbdb-display-records (list record)))
+ (or bbdb-inside-electric-display
+ (not (get-buffer-window bbdb-buffer-name))
+ (let (w)
+ (delete-other-windows)
+ (if (assq 'article gnus-buffer-configuration)
+ (gnus-configure-windows 'article)
+ (gnus-configure-windows 'SelectArticle))
+ (if (setq w (get-buffer-window
+ (if (boundp 'gnus-summary-buffer)
+ gnus-summary-buffer
+ gnus-Subject-buffer)))
+ (select-window w)))))
+ (set-buffer b))
+ (if record (bbdb-display-records (list record))))
record))
;;
Emacs : XEmacs 21.2 (beta27) "Hera" [Lucid] (sparc-sun-solaris2.6, Mule) of Wed Feb
2 2000 on ra.eng.mindspring.net
Package: BBDB 2.32
current state:
==============
(setq
bbdb-version-date "$Date: 2001/03/04 20:27:21 $"
bbdb-file-format 6
bbdb-no-duplicates-p nil
bbdb-after-change-hook '(bbdb/gnus-score-invalidate-alist)
bbdb-after-read-db-hook nil
bbdb-always-add-addresses t
bbdb-auto-notes-alist '(("Newsgroups"
(".*" newsgroups bbdb/gnus-update-newsgroup))
("Organization" (".*" company 0 t)))
bbdb-auto-revert-p nil
bbdb-canonicalize-net-hook nil
bbdb-canonicalize-redundant-nets-p t
bbdb-case-fold-search t
bbdb-change-hook '(bbdb-delete-redundant-nets bbdb-timestamp-hook)
bbdb-completion-display-record nil
bbdb-completion-type nil
bbdb-create-hook '(bbdb-creation-date-hook)
bbdb-default-area-code 614
bbdb-define-all-aliases-field 'mail-alias
bbdb-dial-local-prefix nil
bbdb-dial-local-prefix-alist '(((if bbdb-default-area-code
(format "(%03d)" bbdb-default-area-code) "")
"")
)
bbdb-dial-long-distance-prefix nil
bbdb-dwim-net-address-allow-redundancy nil
bbdb-electric-p nil
bbdb-elided-display nil
bbdb-file "~/.bbdb"
bbdb-file-remote nil
bbdb-file-remote-save-always t
bbdb-finger-host-field 'finger-host
bbdb-gui t
bbdb-hashtable-size 1021
bbdb-ignore-most-messages-alist nil
bbdb-ignore-some-messages-alist nil
bbdb-info-file "/export/home/sj/xemacs/site-lisp/bbdb-cvs/texinfo/bbdb.info"
bbdb-initialize-hook nil
bbdb-list-hook '(bbdb-fontify-buffer)
bbdb-load-hook nil
bbdb-message-caching-enabled t
bbdb-message-marker-field 'gnus-mark
bbdb-mode-hook nil
bbdb-new-nets-always-primary nil
bbdb-north-american-phone-numbers-p t
bbdb-notes-default-separator ", "
bbdb-notes-sort-order '((notes . 0) (www . 1) (ftp . 2) (gopher . 3)
(telnet . 4) (mail-alias . 5) (mail-folder . 6)
(lpr . 7) (creation-date . 1000) (timestamp . 1001))
bbdb-notice-auto-save-file t
bbdb-notice-hook '(bbdb-auto-notes-hook)
bbdb-offer-save 'just-do-it
bbdb-pop-up-elided-display t
bbdb-pop-up-elided-display-fields nil
bbdb-pop-up-elided-display-name-end 48
bbdb-pop-up-target-lines 1
bbdb-quiet-about-name-mismatches nil
bbdb-readonly-p nil
bbdb-refile-notes-default-merge-function 'bbdb-refile-notes-default-merge-function
bbdb-refile-notes-generate-alist '((creation-date .
bbdb-refile-notes-string-least)
(timestamp . bbdb-refile-notes-string-most)
)
bbdb-save-db-timeout nil
bbdb-send-mail-style nil
bbdb-silent-running nil
bbdb-use-alternate-names t
bbdb-user-mail-names "\\(sudish\\|sj\\)@"
bbdb-write-file-hooks '(bbdb-write-file-hook-fn)
bbdb/gnus-lines-and-from-length 18
bbdb/gnus-split-crosspost-default nil
bbdb/gnus-split-default-group "mail.misc"
bbdb/gnus-split-myaddr-regexp "^sj$\\|^sj@\\([-a-z0-9]+\\.\\)*ra.eng.mindspring.net$"
bbdb/gnus-split-nomatch-function nil
bbdb/gnus-split-private-field 'gnus-private
bbdb/gnus-split-public-field 'gnus-public
bbdb/gnus-summary-mark-known-posters t
bbdb/gnus-summary-show-bbdb-names t
bbdb/mail-auto-create-p t
bbdb/news-auto-create-p nil
bbdb/prompt-for-create-p nil
features '(reporter hyper-apropos dired-faces dired-xemacs dired cl-specs
edebug eval-reg tabify supercite regi flow-fill ispell footnote
lazy-lock func-menu filladapt bbdb-xemacs bbdb-gui bbdb-com
bbdb-hooks gnus-picon w3-forms w3-display w3-imap w3-widget css
font w3-mouse w3-vars w3-cus w3-keyword url mm mule-sysdp url-vars
annotations sort gnus-cite mail-extr gnus-async gnus-score
score-mode gnus-ml gnus-msg gnus-art mm-uu binhex uudecode mm-view
gnus-topic utf7 rfc2104 passwd ssl nnimap imap nnfolder nnml
nndraft nnmh gnus-cache efs-cu bbdb-gnus gnus-sum gnus-group
gnus-undo message-x gnus-demon nnmail mail-source format-spec nntp
nnoo gnus-start gnus-range gnus-spec gnus-int gnus-win gnus
gnus-ems gnus-xmas wid-edit message messagexmas mml mml-sec
mml-smime mml2015 smime dig mm-decode mm-bodies mm-encode mailcap
mail-parse rfc2045 rfc2231 rfc2047 qp ietf-drums mailheader
gnus-util time-date parse-time nnheader nnheaderxm mail-utils
mm-util mail-prsvr id-select gnuserv ff-paths ffap-url ffap
complete icomplete paren mic-paren timer zenirc bbdb timezone
mail-init mailcrypt rfc822 mail-hist mail-abbrevs sendmail popper
compile igrep vc vc-hooks env scroll-in-place allout outline
edmacro iswitchb uniquify greedy-delete sawmill inf-lisp comint pp
thingatpt dmacro font-lock face-init iso-syntax disp-table time
url-parse byte-optimize bytecomp byte-compile viper viper-ex
viper-macs viper-mous viper-keym viper-cmd advice advice-preload
viper-util viper-init ring cus-face rsz-minibuf zenirc-autoloads
xslt-process-autoloads xemacs-devel-autoloads
xemacs-base-autoloads w3-autoloads vm-autoloads viper-autoloads
view-process-autoloads vhdl-autoloads vc-autoloads tpu-autoloads
tooltalk-autoloads tm-autoloads time-autoloads textools-autoloads
text-modes-autoloads texinfo-autoloads supercite-autoloads
strokes-autoloads speedbar-autoloads sounds-wav-autoloads
sounds-au-autoloads slider-autoloads sh-script-autoloads
sgml-autoloads semantic-autoloads scheme-autoloads rmail-autoloads
reftex-autoloads psgml-autoloads ps-print-nomule-autoloads
prog-modes-autoloads pcomplete-autoloads pcl-cvs-autoloads
pc-autoloads os-utils-autoloads net-utils-autoloads
misc-games-autoloads mine-autoloads mh-e-autoloads mew-autoloads
mailcrypt-autoloads mail-lib-autoloads ispell-autoloads
ilisp-autoloads igrep-autoloads idlwave-autoloads
hm--html-menus-autoloads gnus-autoloads gnats-autoloads
games-autoloads fsf-compat-autoloads frame-icon-autoloads
forms-autoloads footnote-autoloads eudc-autoloads eterm-autoloads
eshell-autoloads emerge-autoloads elib-autoloads eieio-autoloads
efs-autoloads edt-autoloads edit-utils-autoloads ediff-autoloads
edebug-autoloads dired-autoloads debug-autoloads crisp-autoloads
cookie-autoloads cc-mode-autoloads calendar-autoloads
calc-autoloads c-support-autoloads bbdb-autoloads auctex-autoloads
apel-autoloads ada-autoloads Sun-autoloads skk-autoloads
mule-base-autoloads lookup-autoloads locale-autoloads
leim-autoloads egg-its-autoloads edict-autoloads
Standard-autoloads loadhist auto-show fontl-hooks x-iso8859-1
gutter-items menubar-items x-menubar mouse mode-motion slovenian
czech romanian ccl mule-help itimer auto-save lisp-mode easymenu
iso8859-1 page buff-menu lib-complete derived frame text-props
obsolete cus-start custom widget cl-extra mini-cl cl cl-19
packages backquote very-early-lisp file-coding mule
lucid-scrollbars cut-buffer lucid-menubars motif-dialogs x
tty-frames tty toolbar esd-sound native-sound scrollbar
unix-processes multicast network-streams subprocesses modules
menubar berkeley-db md5 xemacs gutter tiff png gif jpeg xface xpm
xbm lisp-float-type usg-unix-v dialog devices window-system
c-balloon-help base64)
)
_______________________________________________
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/
