On Thu, Sep 01 2005, Steve Youngs wrote: > + * lisp/bbdb-gui.el (bbdb-hack-x-face): Use `emacs-version>=' > + instead of `string-match' against `emacs-version'. This fixes > + X-Face display in SXEmacs now, and also in future versions of > + XEmacs beyond 21.x. [...] > (and (featurep 'xemacs) > - (string-match "^21\\." emacs-version)))) ;; XXX > + (emacs-version>= 21)))) ;; XXX [...] > ;; ripped pretty much verbatim from VM; X Faces for recent XEmacsen. > - ((string-match "^21\\." emacs-version) ;; XXX how far back can I go? > + ((emacs-version>= 21) ;; XXX how far back can I go?
Wouldn't if make more sense to test for features rather than version? Cf. `gnus-image-type-available-p' in `gnus-ems.el'/`gnus-xmas.el'. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/