----- Reiner Steib (2007-01-01) wrote:-----

> On Sat, Dec 30 2006, Patrick Campbell-Preston wrote:
>
>> The primep function in bbdb.el has been broken for a very long while -
>> try (primep 4) or (primep -1) for example.  This is harmless for
>> bbdb's own use of the function, as it happens, but not for the casual
>> user [amusing story omitted].
>>
>> Here's a fixed version, perhaps someone with CVS access and copious
>> free time could paste it in (before the next BBDB release):
>>
>> (defun primep (num)
>
> Wouldn't it be better to rename it to `bbdb-primep'?
>
> ,----[ (info "(elisp)Coding Conventions") ]
> |    * If a package needs to define an alias or a new function for
> |      compatibility with some other version of Emacs, name it with the
> |      package prefix, not with the raw name with which it occurs in the
> |      other version.  Here is an example from Gnus, which provides many
> |      examples of such compatibility issues.
> | 
> |           (defalias 'gnus-point-at-bol
> |             (if (fboundp 'point-at-bol)
> |                 'point-at-bol
> |               'line-beginning-position))
> `----
>
> [ BTW, in Gnus we just had spurious problems because
>   xemacs-base/easy-mmode.el defines `replace-regexp-in-string'. :-/ ]
>
> Bye, Reiner.

I second this.

-- 
Leo <sdl.web AT gmail.com>                         (GPG Key: 9283AA3F)


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/

Reply via email to