On Fri Jan 14 2011 Philipp Haselwarter wrote:
> when I'm in the summary buffer (gnus) and hit ':',
> `bbdb-mua-display-sender' gets called, now without error, but
> nothing happens. 

The problem was that `bbdb-mua-update-records' needs a line

  (set-buffer gnus-article-buffer)

I added this. Yet I also realized something strange about the Gnus
*Article* buffers. The key ':' is not bound to
`bbdb-mua-display-sender' but to `gnus-article-read-summary-keys'
that provides an additional wrapper that restores the window
configuration. So calling `bbdb-mua-display-sender' becomes really
useless inside *Article* buffers.  It only works in the *Summary*
buffer.

-- Suggestions welcome (I do not know much about Gnus).

> b) tab-completion for mail addresses seems broken.
>    In message-mode, TAB is bound to `message-tab', which ends up looking
>    for `bbdb-complete-name' (cf. `message-expand-name').
>    This is unbound, so no bbdb completion happens.
>    I'm not familiar with previous versions of bbdb, but I guess
>    `bbdb-complete-name' used to be what `bbdb-complete-mail' is now?
>    I don't know about the motivation for the renaming, but the problem
>    can be resolved with a simple
>    
>    (defalias 'bbdb-complete-name 'bbdb-complete-mail)

I renamed it to get more consistent function names 

(in BBDB: *-name-* refers to real names, *-mail-* refers to email
addresses).

So I used define-obsolete-function-alias instead.


2011-01-15  Roland Winkler  <wink...@gnu.org>
        * lisp/bbdb-mua.el (bbdb-mua-update-records): For Gnus use
        gnus-article-buffer.
        (bbdb-mua-wrapper): New macro.
        (bbdb-mua-display-records, bbdb-mua-annotate-sender)
        (bbdb-mua-annotate-recipients, bbdb-mua-edit-notes-sender)
        (bbdb-mua-edit-notes-recipients): Use it.
        (bbdb-mua-update-mua): Removed (obsolete because of
        bbdb-mua-wrapper).

        * lisp/bbdb-gnus.el (bbdb-insinuate-gnus): Code doc updated.

        * lisp/bbdb-com.el (bbdb-complete-name): Obsolete alias for
        bbdb-complete-mail.

# To check out:
cvs -d:pserver:anonym...@cvs.sv.gnu.org:/sources/bbdb co bbdb

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/

Reply via email to