27/02/11 18:28, Roland Winkler > I have now given the command bbdb-complete-mail (formerly > bbdb-complete-name) a well-defined return value. It is non-nil only > if the string preceding point is a valid completion so that the > above problem should not exist anymore.
Great, thanks! > On Sun Feb 13 2011 Antoine Levitt wrote: >> 13/02/11 15:31, Roland Winkler >> >> I think the let should be before the if in >> >> bbdb-mua-pop-up-bbdb-buffer. Or even better, bbdb-insinuate would hook a >> >> function to notice contacts, independently from pop-ups. >> > >> > I guess from your perspective bbdb-mua-pop-up-bbdb-buffer is, first >> > of all, a misnomer. The main action is hidden in >> > bbdb-mua-update-records. -- I'll look into this. >> >> Yes. Maybe there should be two separate functions added to the hook, one >> for noticing and the other for displaying the popup. > > Two functions would duplicate things, which is something I'd like to > avoid. Instead, I renamed bbdb-mua-pop-up-bbdb-buffer to > bbdb-mua-auto-update, which, I believe, gives a much clearer idea > what the main purpose of this function is. And bbdb-mua-pop-up-bbdb-buffer > is tested after calling bbdb-mua-update-records. > > In a similar spirit, I also renamed bbdb-mua-pop-up-init to > bbdb-mua-auto-update-init. Also, I extended the doc strings for > bbdb-mua-auto-update-init and bbdb-initialize, because at a first > glance, it is a bit confusing that these two functions appear to do > similar things. Perfect, I just tried it and it works very nicely. There's a typo though: Index: bbdb-mua.el =================================================================== RCS file: /sources/bbdb/bbdb/lisp/bbdb-mua.el,v retrieving revision 1.5 diff -r1.5 bbdb-mua.el 776,777c776,777 < Call this function in you init file to use the auto update feature with MUAS. < This function is seaparate from the general function `bbdb-initialize' --- > Call this function in your init file to use the auto update feature with MUAS. > This function is separate from the general function `bbdb-initialize' Antoine ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
