Stephen Leake <stephen_le...@stephe-leake.org> writes:
> I'm trying to understand how email address cycling is supposed to work.
>
> I have TAB bound to (bbdb-complete-mail nil t).
That final 't' defeats cycling, popping up a completion window instead.
So I've deleted it.
> I've traced thru several executions of bbdb-complete-mail, with various
> patterns, and various settings of bbdb-completion-list. It appears there
> is no way to get to the line ";; Consider cycling" with 'done' set to
> nil, so there is no way to get cycling. I hope I'm wrong!
If I delete "(not done)" on that "when" statement, leaving:
;; Consider cycling
(when bbdb-complete-mail-allow-cycling
then I get cycling; hitting TAB after getting to one record replaces the
current email address with the next on in the list of email address for
that record.
Which makes sense, and is the behavior I want. And so far, it hasn't
done anything I don't want.
So I'll leave my copy of the code with that edit, and see what else
happens.
I also fixed a bug; the code for "Clean up *Completions*" tries to kill
a non-existent window (it was already killed by
set-window-configuration). See patch below.
--
-- Stephe
diff --git a/lisp/bbdb-com.el b/lisp/bbdb-com.el
old mode 100644
new mode 100755
index d39b823..8ba74f0
--- a/lisp/bbdb-com.el
+++ b/lisp/bbdb-com.el
@@ -1801,8 +1801,8 @@ as part of the MUA insinuation."
;; Clean up *Completions* buffer, if it exists
(when bbdb-complete-mail-saved-window-config
(let ((window (get-buffer-window "*Completions*")))
+ (set-window-configuration bbdb-complete-mail-saved-window-config)
(when (window-live-p window)
- (set-window-configuration bbdb-complete-mail-saved-window-config)
(quit-window nil window)))
(setq bbdb-complete-mail-saved-window-config nil))
@@ -1912,7 +1912,7 @@ as part of the MUA insinuation."
(t (setq done 'choose))))))
;; Consider cycling
- (when (and (not done) bbdb-complete-mail-allow-cycling)
+ (when bbdb-complete-mail-allow-cycling
;; find the record we are working on.
(let* ((address (mail-extract-address-components orig))
(record (and (listp address)
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/
