On Monday 02 January 2006 00:15, Felix Fietkau wrote: > Hi BCM43xx hackers. > > I'm one of the OpenWrt developers and I'm currently working on > integrating your driver into our development branch. I've written a > patch which adds support for a BCM43xx core integrated into the main SB > of the BCM47xx SoC. It applies against the dscape branch, which I intend > to use, but it should be easy to port it to trunk. Some people on > irc.sipsolutions already reviewed an earlier version, so it would be > nice if you could commit this version to SVN. > While testing it, I was able to associate with another AP, but couldn't > transfer any data (had to hack some of the rate stuff for testing, this > might be the problem).
Applied, but I added two FIXMEs.
Could you take a look, please?
@@ -1472,6 +1513,8 @@
u32 flags = 0x00040000;
if ((bcm43xx_core_enabled(bcm)) && (!bcm->pio_mode)) {
+//FIXME: Do we _really_ want #ifndef CONFIG_BCM947XX here?
+#ifndef CONFIG_BCM947XX
/* reset all used DMA controllers. */
bcm43xx_dmacontroller_tx_reset(bcm, BCM43xx_MMIO_DMA1_BASE);
bcm43xx_dmacontroller_tx_reset(bcm, BCM43xx_MMIO_DMA2_BASE);
@@ -4252,6 +4309,8 @@
err = -ENODEV;
goto err_pci_disable;
}
+//FIXME: Why is this check disabled for BCM947XX? What is the IO_SIZE there?
+#ifndef CONFIG_BCM947XX
if (mmio_len != BCM43xx_IO_SIZE) {
printk(KERN_ERR PFX
"%s: invalid PCI mem region size(s), aborting\n",
--
Greetings Michael.
pgpN6Q48ff5JN.pgp
Description: PGP signature
