Jory A. Pratt wrote:
> Michael Buesch wrote:
>   
>> On Wednesday 24 January 2007 20:08, Larry Finger wrote:
>>   
>>     
>>> Michael Buesch wrote:
>>>     
>>>       
>>>> On Wednesday 24 January 2007 19:39, Larry Finger wrote:
>>>>       
>>>>         
>>>>>   switch (led_index) {
>>>>>   case 0:
>>>>>           led->behaviour = BCM43xx_LED_ACTIVITY;
>>>>> +         led->activelow = 1;
>>>>>         
>>>>>           
>>>> Why activelow?
>>>>       
>>>>         
>>> It makes the light be on when there is no activity and blink off when there 
>>> is. With that behavior,
>>> it is a lot easier to see that the switch is on.
>>>     
>>>       
>> Ah, ok.
>> It's debatable if that behaviour is desireable.
>> I don't like it, but if people want to have it, we can implement it.
>>
>>   
>>     
> I do not think this is what people want. If the radio is off the light
> should just be off, when radio is on turn the light on, is a much more
> desirable.
>
> Thanks,
> -Jory
> _______________________________________________
> Bcm43xx-dev mailing list
> [email protected]
> https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
>
> !DSPAM:6251,45b7e6db63428126216758!
>
>
>   
My understanding of the proposed behavior is:
    Radio on: led on
    Radio off: led off
    Activity: flash on-off-on ...

This is the same behavior as my Buffalo WHR-HP-G54 and seems reasonable.

Steve


_______________________________________________
Bcm43xx-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Reply via email to