On Thursday 15 November 2007 16:02:48 Larry Finger wrote:
> >> @@ -695,11 +687,12 @@ static int dmacontroller_setup(struct b4
> >>                    b43_dma_write(ring, B43_DMA32_RXRING,
> >>                                  (ringbase & ~SSB_DMA_TRANSLATION_MASK)
> >>                                  | trans);
> >> -                  b43_dma_write(ring, B43_DMA32_RXINDEX, 200);
> >> +                  b43_dma_write(ring, B43_DMA32_RXINDEX, ring->nr_slots *
> >> +                                sizeof(struct b43_dmadesc32));
> > 
> > I'm not sure why you do this change.
> 
> It took me a while to figure out where the magic number of 200 came from, and 
> what I needed for the
> 64-bit case. In fact I think the 200 is a bug and should be 0x200. To me, 
> this change makes it clearer.

The 200 is just a random number.
I think we don't really care what the value is. (Except zero, which doesn't
work on some devices).

-- 
Greetings Michael.
_______________________________________________
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Reply via email to