On Monday 10 December 2007 18:23:21 Larry Finger wrote: > This version of the rfkill switch patch is pretty straight forward. Please > comment on the dropping of wl->mutex before rfkill initialization. This is > the only way I could avoid the circular locking without a much earlier > rfkill initialization.
I think that's not acceptable, as it introduces a nasty (although unlikely) race condition with the band switch. I will think about it and will fix it myself then. If there's no way to properly fix it, I think it may also be OK to live with this damn unlikely race. Please also add the call to request_module() into the rfkill init and test if it works properly. After that, please send the complete patch back to me and I will try to fix the locking issue. Anyway, this patch looks nice. Good work. -- Greetings Michael. _______________________________________________ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
