On Wednesday 26 August 2009 23:38:48 Gábor Stefanik wrote:
> From: root <r...@nr3dmain.nr3d>
>
> After some discussion on IRC about the PHY register write change,
> I am not sure anymore if this is the right thing to do.
>
> Signed-off-by: Gábor Stefanik <netrolller...@gmail.com>
> ---
> drivers/net/wireless/b43/phy_lp.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/phy_lp.c
> b/drivers/net/wireless/b43/phy_lp.c
> index 80f245c..a57c40d 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -1496,7 +1496,8 @@ static u16 b43_lpphy_op_read(struct b43_wldev *dev, u16
> reg)
>
> static void b43_lpphy_op_write(struct b43_wldev *dev, u16 reg, u16 value)
> {
> - b43_write32(dev, B43_MMIO_PHY_CONTROL, ((u32)value << 16) | reg);
> + b43_write32(dev, B43_MMIO_PHY_CONTROL, reg);
> + b43_write32(dev, B43_MMIO_PHY_DATA, value);
You just introduced a bug (need 16bit write).
As I said. I'm OK with it, if it works. Just submit it as separate patch in the
future.
> }
>
> static void b43_lpphy_op_maskset(struct b43_wldev *dev, u16 reg, u16 mask,
--
Greetings, Michael.
_______________________________________________
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
