On Sunday 28 February 2010 02:37:21 Rafał Miłecki wrote: > W dniu 27 lutego 2010 15:51 użytkownik Michael Buesch <m...@bu3sch.de> > napisał: > > On Saturday 27 February 2010 12:12:23 Rafał Miłecki wrote: > >> 2010/2/10 Michael Buesch <m...@bu3sch.de>: > >> > On Tuesday 09 February 2010 21:04:33 Rafał Miłecki wrote: > >> >> +#define B43_MMIO_PSM_PHY_HDR 0x492 /* programmable state > >> >> machine */ > >> > > >> > The comment doesn't make a lot of sense. > >> > In case you don't know, the PSM is the part of the hardware > >> > that executes the firmware. > >> > >> Well, guess you're right. It was me hearing for the first time "PSM" > >> so decided to write it. Guess it's pretty obvious for every device > >> driver developer :) > >> > > > > Well, what I wanted to say is that it's more important to explain > > what PHY_HDR means. Something like /* PSM PHY header */ ? > > Sure, explaining HDR sounds great, but do you actually know it's > header? Personally I have no idea, so I am not sure if you know that > with nice probability of being right, or are you just guessing? :)
Well, I assumed you could deduce the meaning from the code. If not, it's better to leave it without a comment. I don't know for sure what this means. But declaring the definition as "Programmable State Machine" is also wrong. So let's simply leave it without a comment. -- Greetings, Michael. _______________________________________________ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
