On Sun, Jul 11, 2010 at 12:14:27PM -0400, Chris Ball wrote: > Hi Gour, > > > shortname = self.bd.bug_shortname(bug) > > AttributeError: 'BugDir' object has no attribute 'bug_shortname' > > Yeah, there are still many API changes to fix. All instances of: > > self.bd.bug_shortname(bug) > > should be replaced with: > > bug.id.user()
This raises the issue of possible changes to
'/bug?id=%s' % shortname
If we use
'/bug?id=%s' % bug.id.user()
we could end up with
/bug?id=abc%2Fdef
which is ugly with '/' -> '%2F'. I think we should use
'/%s' % bug.id.user()
But I'm not sure how to catch those URLs in CherryPy, so perhaps
'/bug?' % urllib.urlencode({'id': bug.id.storage()})
is the way to go.
On the input side, we should use
libbe.command.util.bug_comment_from_user_id()
to load the appropriate bug from a user given ID (via the URL). This
would let the user truncate the ID if they wanted (vs. the canonical
bug.id.long_user()), at the risk of long-term unreliability.
Thoughts?
--
This email may be signed or encrypted with GPG (http://www.gnupg.org).
The GPG signature (if present) will be attached as 'signature.asc'.
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
My public key is at http://www.physics.drexel.edu/~wking/pubkey.txt
pgpyVk8Z9VeaM.pgp
Description: PGP signature
_______________________________________________ Be-devel mailing list [email protected] http://void.printf.net/cgi-bin/mailman/listinfo/be-devel
