>It's a shame to inherit so much of the mess from 
>/distribution/virt/install, looking at it all again really makes me 
>think it would be worthwhile doing a rewrite targetting RHEL6+ only (or 
>even RHEL7+ only?) to eliminate some of the unnecessary workarounds and 
>simplify.

Yes, I agree.

>One minor issue in your get_user_data.py, it looks like the chpasswd 
>invocation will not work properly if the root password is encrypted in 
>the kickstart (which it normally is). Pykickstart can probably tell you 
>if --crypted was in the kickstart and if so just pass -e to chpasswd to 
>tell it the password is already encrypted.

>Also, it would probably be more efficient to install all packages in 
>a single yum transaction instead of emitting a separate yum install 
>command for each line in %packages.

Thanks for pointing that, I will make changes to the code.

Cheers,Matt Jia
_______________________________________________
Beaker-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/beaker-devel

Reply via email to