ownership as in the official repo. being in the official group means something. I feel like you are just dismissing my efforts.
On Thursday, January 26, 2023 at 10:52:39 AM UTC-5 dan...@grinta.net wrote: > On 26/01/2023 16:31, polarmutex wrote: > > > > I am happy to work together and make changes to clean it up(no one has > > submitted issues about it). I just feel slighted that I did not get a > > chance to be merged into the group when I have been working it for a > > while. > > I forgot about your messages to the mailing list about your efforts to > implement the tree-sitter grammar for Beancount. I didn't see any > request to bring it into the beacount organization on Github. If that > would have happened, I would have had a look at it and I would have > noticed the shortcomings before and we could have worked to resolve them. > > It's not ideal that there are two projects with the same scope. I'm > happy to collaborate on this. However, I think that the changes required > to fix your parser are very close to a rewrite: the scanner needs to be > extended to handle indentation and the grammar nodes extensively reworked. > > I would greatly appreciate if you could look at my grammar and determine > whether there are shortcomings that make it unusable for your use cases. > I know that node field names are missing. However, these can be added > where needed, and I believe this is much less invasive than fixing your > grammar according to my vision. > > > Should I merge my lsp in to claim ownership? > > Ownership of what? Isn't it your project already? > > Cheers, > Dan > > > > I have been making > > changes to the grammar based upon issues and trying to be a nice player > > in the OSS community. I never said my grammar was perfect but I have > > posted about it on this group before and have been working it for a > while. > > > On Thursday, January 26, 2023 at 10:20:05 AM UTC-5 dan...@grinta.net > wrote: > > > > (I realized I left a sentence incomplete) > > > > > 2. it does not correctly work with account names in the whole > > Unicode > > > range, it mimics the hack implemented for > > > > Flex, which has only primitive regular expressions. tree-sitter > > supports > > regular expressions matching unicode character classes, thus a much > > better job can be made. > > > > Cheers, > > Dan > > > > -- > > You received this message because you are subscribed to the Google > > Groups "Beancount" group. > > To unsubscribe from this group and stop receiving emails from it, send > > an email to beancount+...@googlegroups.com > > <mailto:beancount+...@googlegroups.com>. > > To view this discussion on the web visit > > > https://groups.google.com/d/msgid/beancount/4e7193e6-c860-4c83-8014-357295b3e117n%40googlegroups.com > > < > https://groups.google.com/d/msgid/beancount/4e7193e6-c860-4c83-8014-357295b3e117n%40googlegroups.com?utm_medium=email&utm_source=footer > >. > > -- You received this message because you are subscribed to the Google Groups "Beancount" group. To unsubscribe from this group and stop receiving emails from it, send an email to beancount+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/beancount/3e2fcf8d-1915-465a-911f-f25edd8c05ebn%40googlegroups.com.
