On Sun, Jul 23, 2023 at 3:19 AM Daniele Nicolodi <dani...@grinta.net> wrote:
> On 23/07/23 03:58, Eric Altendorf wrote: > ... > > I'm not sure how one is supposed to run multiple importers at once, the > > doc kind of only describes running one. > > This is a design document, not user documentation. What has been > implemented does not necessarily exactly reflects that design. > Unfortunately the documentation for beangulp is coming along slowly. The > best there is are probably the examples in the package. > Sorry, I just meant to imply that I have tried to follow guidance where I could. Looking at the code was indeed how I got it running, but I was looking for confirmation because sometimes also code isn't up to date or doing things in the recommended ways :) > > This looks correct, but you can simplify it a tiny bit: the Ingest > object can be called directly: > > ingest = beangump.Ingest(importers, hooks) > ingest() > Cool. What does the `cli` object do, anyway? I'm not super experienced in Python and I wasn't sure I fully understood what was going on there. > It should, but I just found that indeed I overlooked some divergence in > the code paths between the time the intra-importer deduplication patches > were written and the time I merged them. As a result, the intra-importer > deduplication is not run. This is what you get when you leave patches > not merged for years. I'm fixing it now. > Thank you for the fix, I believe it's working for me now! > > There seems to be a fairly good default implementation of similarity > > comparison, yes? > > "fairly good" ? > > > Hmm, OK, that may work fine, thanks. > > "may work fine" ? > > These tools have been written to scratch the itch of the persons that > wrote them. If you think that you can find something better elsewhere, > or that you can write something better yourself, you are free to do so. > Just let me know and I'll process a refund for your support contract. > I am very sorry, that was a poor choice of words and came across wrong. I had looked over the similarity/deduping code and it appeared to me that it had been written with the expectation that the default setup would work out of the box for many cases users would run into. I just wanted to confirm that was the intention, as opposed to, say, that it was an example implementation only, or only for particular use cases, with the expectation that users ought to override it with their own implementation. I also have an open source project on github and you provide 100x better service than I ever did :) eric -- You received this message because you are subscribed to the Google Groups "Beancount" group. To unsubscribe from this group and stop receiving emails from it, send an email to beancount+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/beancount/CAFXPr0ty3ZcAZs6oUEq6YUX02%3Dbx-GrXfCR5pyqPSoLm%2B0AoDg%40mail.gmail.com.
