Hi Stefan, thanks for the PR.
Overall it looks good, there's one thing that can be improved though.
I'd like to keep all thresholds in one place, in the Makefile.sub. I see two
ways to accomplish that:
a) Change configure.ac's FLUID_THRESHOLD to a FLUID_RELAXED_THRESHOLD boolean
and pick the threshold inside the Makefile based on the boolean.
b) Change configure.ac's FLUID_THRESHOLD to FLUID_VERSION and pick a threshold
inside the Makefile based on FLUID_VERSION>=1.1.7.
I guess (a) suffices for now, but (b) would be more future proof in case we
have to adjust the threshold ever again. Come to think of it, we could run into
future problems with other libraries as well. Scattering the threshold and
version checks across Makefile.sub and configure.ac for each should be avoided.
I.e. I'd merge either (a) or (b), but have a slight preference for (b) in terms
of setting a precedent for future patches.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tim-janik/beast/pull/42#issuecomment-395023503
_______________________________________________
beast mailing list
beast@gnome.org
https://mail.gnome.org/mailman/listinfo/beast
