I've ported all Track properties to C++ that do not contain object references. 
Two things are worth mentioning.

1. `Const MIDI_MAX_CHANNEL` - I declared this as constant, but maybe the 
definition must be moved elsewhere. It seems to be required in bsebasics.idl, 
too (there is a `// FIXME: MAX_MIDI_CHANNEL` in the `MidiChannelEvent` 
definition)
2. I didn't touch `"signal::property-notify::n-voices"` and similar signal code 
in bsttrackview.cc, I'm not sure what the C++ property equivalent would be
You can view, comment on, or merge this pull request online at:

  https://github.com/tim-janik/beast/pull/109

-- Commit Summary --

  * BSE: Track::muted: port property to C++
  * BEAST-GTK: bsttrackview: use muted C++ property
  * BSE: Track::midi_channel: port property to C++
  * BEAST-GTK: bsttrackview: use midi_channel C++ property
  * BSE: Track::n_voices: port property to C++
  * BEAST-GTK: bsttrackview: use n_voices C++ property

-- File Changes --

    M beast-gtk/bsttrackview.cc (26)
    M bse/bseapi.idl (16)
    M bse/bsetrack.cc (107)
    M bse/bsetrack.hh (6)

-- Patch Links --

https://github.com/tim-janik/beast/pull/109.patch
https://github.com/tim-janik/beast/pull/109.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tim-janik/beast/pull/109
_______________________________________________
beast mailing list
beast@gnome.org
https://mail.gnome.org/mailman/listinfo/beast

Reply via email to