Re: [jira] Created: (BEEHIVE-154) Revert changes made in ControlBean.vm to accomodate IDEs that are not fully JDK5 compliant

[Bryan Che]

There is another class in Netui that Eclipse 3.1 can't compile now due 
to autoboxing.  Can we patch that file too and then update this Jira to 
track that one as well?  I've attached the patch.

(BTW, I found this benchmark of autoboxing last year to be interesting: 
http://www.javaspecialists.co.za/archive/Issue090.html)

Bryan
Hoi Lam (JIRA) wrote:
Revert changes made in ControlBean.vm to accomodate IDEs that are not fully 
JDK5 compliant
------------------------------------------------------------------------------------------
         Key: BEEHIVE-154
         URL: http://issues.apache.org/jira/browse/BEEHIVE-154
     Project: Beehive
        Type: Task
  Components: Controls  
    Versions: V1Beta    
    Reporter: Hoi Lam
 Assigned to: Hoi Lam 
    Priority: Minor
     Fix For: V1

A change was made in ControlBean.vm to accomodate Eclipse 3.1 Mx that is not fully JDK5 compliant, specifically where their language processor doesn't support autoboxing.  In this case, when a control method  returns a primitive type, the generated control bean cannot be compiled by the IDE.  A change was made to wrap an primitive types in their corresponding wrapper classes.  This change should be reverted when Eclipse no long has this issue.  

When reverting this change look for the following comment in the code and 
following the instruction in the comment:
            ##Wrapping primitives with their corresponding wrapper class
            ##will not be necessary once  Javelin and other IDEs become 
            ##fully compliant with JDK5.
            ##In this case, we can replace the if statement below with:
            ## #if ($returnType == "void")
            ## Object rv = null;
            ## #else
            ## Object rv = retval;        


Index: 
netui/src/tags-databinding/org/apache/beehive/netui/databinding/datagrid/services/pager/PagerService.java
===================================================================
--- 
netui/src/tags-databinding/org/apache/beehive/netui/databinding/datagrid/services/pager/PagerService.java
   (revision 124439)
+++ 
netui/src/tags-databinding/org/apache/beehive/netui/databinding/datagrid/services/pager/PagerService.java
   (working copy)
@@ -66,7 +66,7 @@
 
     public Integer getCurrentPage() {
         if(getCurrentRow() != null && getPageSize() != null)
-            _currentPage = (int)Math.ceil((double)getCurrentRow() / 
(double)getPageSize());
+            _currentPage = 
(int)Math.ceil((double)getCurrentRow().doubleValue() / 
(double)getPageSize().doubleValue());
         
         return _currentPage;
     }