Comments in line.
Jeremiah Johnson wrote:
I've never really looked at the nightly script - I took a look just now and am curious about a couple things: svnversion and no clean.dist.
The svnversion has 'fail on error' set to false here. I can understand that setting in the other build scripts, but svnversion is important for the nightlies. If svnversion fails because of a glitch in the Apache servers or something temporary, then I don't think that the nightly should be built at that time.
Yes -- totally true. I'll fix that.
I assumed that there would be a clean.dist before the nightly is built, but there really isn't any reason for that assumption. I am curious, though - do you intend to keep past nightlies on the nightly build machine as well as on Apache? Not a big deal - am just curious what the process is on this.
The top-level "clean" takes care of this and is more aggressive than "clean.dist". No need to run both.
Not sure how many nightlies we'll keep around -- probably not many since it puts a burden on Apache's infrastructure.
There is no Nightly wiki page that I could see, but while looking I did notice that the Distribution Structure page is pretty far out of date. Some of the stuff (i.e. templates) could use a touch from a developer like whether that stuff is still planned or if samples/netui-blank is the final solution.
Yep -- totally agree. Someone should update that at some point. :) I'll get to it once I've got a few other things (samples / Javadoc) taken care of.
Thanks for the feedback.
Eddie
- jeremiah
-----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, May 05, 2005 10:06 AM To: [EMAIL PROTECTED] Subject: svn commit: r168348 -
/incubator/beehive/trunk/ant/nightly.xml
Author: ekoneil Date: Thu May 5 09:05:49 2005 New Revision: 168348
URL: http://svn.apache.org/viewcvs?rev=168348&view=rev Log: Enable the full clean / deploy / drt cycle for the SVN tree before creating a nightly build.
BB: self Test: full nightly build
Modified: incubator/beehive/trunk/ant/nightly.xml
Modified: incubator/beehive/trunk/ant/nightly.xml URL:
http://svn.apache.org/viewcvs/incubator/beehive/trunk/ant/nightly.xml?re v=
168348&r1=168347&r2=168348&view=diff
======================================================================== ==
==== --- incubator/beehive/trunk/ant/nightly.xml (original) +++ incubator/beehive/trunk/ant/nightly.xml Thu May 5 09:05:49 2005 @@ -33,11 +33,10 @@
<antcall target="scrub.tomcat"/>
-<!-- <ant antfile="../build.xml" target="clean"
inheritAll="false"/>
<ant antfile="../build.xml" target="deploy"
inheritAll="false"/>
<ant antfile="../build.xml" target="drt" inheritAll="false"/> ---> + <ant antfile="../build.xml" target="build.dist" inheritAll="false"> <property name="beehive.version"
value="${beehive.version}"/>
</ant>
