[ 
http://issues.apache.org/jira/browse/BEEHIVE-717?page=comments#action_12313080 
] 

daryoush mehrtash commented on BEEHIVE-717:
-------------------------------------------

Thanks eddie for the commit and the  Asserts you added improved the code, well  
except this one (line 82 on Control Provider)

           assert !(origExp instanceof AxisFault) : "Unexpected: found 
AxisFault as detail of AxisFault";

To have AxisFault in the detail is unexpected, we don't expect one to wrap 
AxisFault inside another.  But if they do, well that means they can deal with 
the serailzation also, which means we don't need our Adaptor.  I think the 
original code: 

           if (origExp instanceof AxisFault)
                throw e; // Should not happen, just being paranoid.
            // AxisFaults are not wrapped in another, but just in case!

Is a better representation of the reality than an Assert.


> minor non-conformance of exceptions to JSR-181 / JAX-RPC 1.1
> ------------------------------------------------------------
>
>          Key: BEEHIVE-717
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-717
>      Project: Beehive
>         Type: Bug
>   Components: Web Services (181)
>     Versions: V1Beta
>  Environment: Beehive SVN 169852
>     Reporter: Jeremiah Johnson
>     Assignee: daryoush mehrtash
>     Priority: Minor
>      Fix For: TBD
>  Attachments: BEEHIVE-133.tar.gz, BEEHIVE-133.wsdl, faultpatch.txt, 
> faultpatch.txt
>
> While testing BEEHIVE-133, we ran into an issue with user-defined Exceptions. 
>  The example provided in the JAX-RPC v1.1 spec shows the problem, so I will 
> attach that as the repro.  The WSDL looks accurate according to the JAX-RPC 
> spec (which is referenced by JSR 181), but the response message looks 
> incorrect.
> I will attach the WSDL; the incorrect looking response is below:
> <soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/"; 
> xmlns:xsd="http://www.w3.org/2001/XMLSchema"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";>
>  <soapenv:Body>
>   <soapenv:Fault>
>    <faultcode>soapenv:Server.userException</faultcode>
>    <faultstring>web.InvalidTickerException</faultstring>
>    <detail>
>     <ns1:hostname 
> xmlns:ns1="http://xml.apache.org/axis/";>localhost.localdomain</ns1:hostname>
>    </detail>
>   </soapenv:Fault>
>  </soapenv:Body>
> </soapenv:Envelope>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to