On Wed, Feb 18, 2009 at 19:59, Gunnar Hjalmarsson <nore...@gunnar.cc> wrote: > Chas. Owens wrote: snip >> This is not the best way to go about solving this problem (use diff or a >> module like Text::Diff*), > > If we are going to suggest a module, List::Compare would be more to the > point IMO. snip
No, the lines should not make it out of the files into arrays in the first case. Reading whole files into arrays is one of the reasons this code is bad. snip >> It is important to note that this algorithm only works if you care about >> unique lines. If you need to know that file1 has 5 lines of "foo" and file2 >> has 4 lines of "foo", this code will not tell you that. > > Since the files contain file names from directory listings, that cannot be > applicable to the problem at hand. snip Yes, but it is an important thing to note lest you try to use it for something else later. -- Chas. Owens wonkden.net The most important skill a programmer can have is the ability to read. -- To unsubscribe, e-mail: beginners-unsubscr...@perl.org For additional commands, e-mail: beginners-h...@perl.org http://learn.perl.org/
