Yes, ptr is not defined if not enable HAS_BO_SET_SOFTPIN. The patch LGTM, but I think define the ptr outside the HAS_BO_SET_SOFTPIN is more clearly.
> -----Original Message----- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Guo, Yejun > Sent: Friday, November 25, 2016 15:49 > To: beignet@lists.freedesktop.org > Cc: Guo, Yejun <yejun....@intel.com> > Subject: [Beignet] [PATCH] fix build issue when HAS_BO_SET_SOFTPIN is > false > > Signed-off-by: Guo, Yejun <yejun....@intel.com> > --- > src/cl_mem.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/cl_mem.c b/src/cl_mem.c index 2b783b9..6a4729d 100644 > --- a/src/cl_mem.c > +++ b/src/cl_mem.c > @@ -801,9 +801,10 @@ void* cl_mem_svm_allocate(cl_context ctx, > cl_svm_mem_flags flags, > > /* Append the svm in the context buffer list */ > cl_context_add_mem(ctx, mem); > -#endif > - > return ptr; > +#else > + return NULL; > +#endif > } > > void > -- > 1.9.1 > > _______________________________________________ > Beignet mailing list > Beignet@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/beignet _______________________________________________ Beignet mailing list Beignet@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/beignet