The suggested changes don't work correctly for one specific case. 
This means that when running Jwdp under Win32 without
Edit|Configure|External Programs|Web Browser defined, the links to Help
files don't work (eg. Help|General Info).

The following changes to the 2nd if. statement in the launch verb of
~system/extras/util/browser.ijs should sort things out.

NEWCODE:
==================================
isURL=. 1 e. '://'&E.
if. 0=IFUNIX+#browser do.
  if. IFJAVA *. -. isURL cmd do.
    start=. ''
  else.   start=. 'start "" ' end.
  cmd=. 'cmd /C ',start,quoteit cmd
  show=. ' sw_hide'
else.
  browser=. quoteit browser
  cmd=. '/' (I. cmd='\') } cmd
  if. -. isURL cmd do.
    cmd=. 'file://',cmd
  end.
  cmd=. browser,' ',quoteit cmd
  show=. ''
end.
===================================

OLD CODE:
===================================
if. 0=IFUNIX+#browser do.
  cmd=. 'cmd /C start "" ',quoteit cmd
  show=. ' sw_hide'
else.
  browser=. quoteit browser
  cmd=. '/' (I. cmd='\') } cmd
  if. -. 1 e. '://' E. cmd do.
    cmd=. 'file://',cmd
  end.
  cmd=. browser,' ',quoteit cmd
  show=. ''
end.
===================================

> -----Original Message-----
> From: [EMAIL PROTECTED] 
> [mailto:[EMAIL PROTECTED] On Behalf Of Chris Burke
> Sent: Friday, 15 February 2008 23:10
> To: Beta forum
> Subject: Re: [Jbeta] Info Button on Package manager fails in 
> j & k win32 builds
> 
> I made these changes in the latest scripts (018). Thanks for the 
> suggestions.
> 
> Sherlock, Ric wrote:
> > This works fine for me as long as a web browser is defined in
> > Edit|Configure|External Programs. If not, I also get the following
> > error.
> > 
> > To fix the problem I'd consider changing launch_jbrowser_ 
> to work with
> > URLs as well as filenames and then use it rather than 
> duplicating the
> > same mechanism in browser_view. I don't think this would be 
> too hard.
> > For example ...
> > launch[6] from:
> >  cmd=. 'cmd /C ',quoteit cmd
> > to:
> >  cmd=. 'cmd /C start "" ',quoteit cmd
> > 
> > 
> > and a mechanism for recognizing a url rather than a filename in the
> > following else. block. Example ...
> > else.
> >  browser=. quoteit browser
> >  if. (# <: '://' i.&1@:E. ]) cmd do.
> >   cmd=. '/' (I. cmd='\') } cmd
> >   cmd=. 'file://',cmd
> >  end.
> >  cmd=. quoteit cmd
> >  cmd=. browser,' ',cmd
> >  show=.''
> > end.
> > 
> > browser_view in pacman.ijs could then be simplified to just:
> > 
> > browser_view=: 3 : 0
> >   require '~system/extras/util/browser.ijs'
> >   launch_jbrowser_ y

----------------------------------------------------------------------
For information about J forums see http://www.jsoftware.com/forums.htm

Reply via email to