Revision: 20843 http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=20843 Author: sirdude Date: 2009-06-13 05:08:58 +0200 (Sat, 13 Jun 2009)
Log Message: ----------- coverity issue CID: 523 Checker: UNINIT (help) File: base/src/source/blender/blenlib/intern/freetypefont.c Function: objchr_to_ftvfontdata Description: Using uninitialized value "face" in call to function "freetypechar_to_vchar" freetypechar_to_vchar expects face to be defined so we need to return before then if we have a problem. Also it doesn't make sense to not return FALSE if there is an error because we didn't do anything. Kent Modified Paths: -------------- trunk/blender/source/blender/blenlib/intern/freetypefont.c Modified: trunk/blender/source/blender/blenlib/intern/freetypefont.c =================================================================== --- trunk/blender/source/blender/blenlib/intern/freetypefont.c 2009-06-13 03:05:20 UTC (rev 20842) +++ trunk/blender/source/blender/blenlib/intern/freetypefont.c 2009-06-13 03:08:58 UTC (rev 20843) @@ -301,9 +301,12 @@ tf->pf->size, 0, &face); + if (err) return FALSE; } - else - err= TRUE; + else { + err = TRUE; + return FALSE; + } // Read the char freetypechar_to_vchar(face, charcode, vfont->data); _______________________________________________ Bf-blender-cvs mailing list Bf-blender-cvs@blender.org http://lists.blender.org/mailman/listinfo/bf-blender-cvs