[Bf-blender-cvs] [0916ed8dbe6] soc-2019-adaptive-cloth: Cloth: fixed eigen decomposition floating point errors

[ishbosamiya]

Commit: 0916ed8dbe66cbbb982aea37363b167462de1adc
Author: ishbosamiya
Date:   Thu Aug 1 00:11:11 2019 +0530
Branches: soc-2019-adaptive-cloth
https://developer.blender.org/rB0916ed8dbe66cbbb982aea37363b167462de1adc

Cloth: fixed eigen decomposition floating point errors

This should generally work but needs further testing. Currently, the plan to 
check for floating point errors in compression metric.

===================================================================

M       source/blender/blenkernel/intern/cloth_remeshing.cpp

===================================================================

diff --git a/source/blender/blenkernel/intern/cloth_remeshing.cpp 
b/source/blender/blenkernel/intern/cloth_remeshing.cpp
index d527a82e27b..aa8899e8e09 100644
--- a/source/blender/blenkernel/intern/cloth_remeshing.cpp
+++ b/source/blender/blenkernel/intern/cloth_remeshing.cpp
@@ -87,12 +87,13 @@ class ClothPlane {
 
 #define REMESHING_DATA_DEBUG 0 /* split and collapse edge count */
 #define COLLAPSE_EDGES_DEBUG 0
-#define FACE_SIZING_DEBUG 0
-#define FACE_SIZING_DEBUG_COMP 0
+#define FACE_SIZING_DEBUG 1
+#define FACE_SIZING_DEBUG_COMP 1
 #define FACE_SIZING_DEBUG_OBS 0
 #define FACE_SIZING_DEBUG_SIZE 0
 
 #define INVERT_EPSILON 0.00001f
+#define EIGEN_EPSILON 1e-3f
 #define NEXT(x) ((x) < 2 ? (x) + 1 : (x)-2)
 #define PREV(x) ((x) > 0 ? (x)-1 : (x) + 2)
 
@@ -1796,15 +1797,32 @@ static void cloth_remeshing_eigen_decomposition(float 
mat[2][2], float r_mat[2][
   r_vec[1] = l2;
 
   float v0, v1, vn;
-  if (b) {
+  /* EIGEN_EPSILON is used due to floating point precision errors */
+  /* TODO(Ish): It might be possible to just use fabsf(b2) instead of
+   * fabsf(b), this would eliminate the need for the nested if */
+  if (fabsf(b) < EIGEN_EPSILON) {
     v0 = l1 - d;
     v1 = b;
     vn = sqrtf(v0 * v0 + b2);
+    if (fabsf(vn) < EIGEN_EPSILON) {
+      r_mat[0][0] = 0;
+      r_mat[1][0] = 1;
+      r_mat[0][1] = 1;
+      r_mat[1][1] = 0;
+      return;
+    }
     r_mat[0][0] = v0 / vn;
     r_mat[1][0] = v1 / vn;
 
     v0 = l2 - d;
     vn = sqrtf(v0 * v0 + b2);
+    if (fabsf(vn) < EIGEN_EPSILON) {
+      r_mat[0][0] = 0;
+      r_mat[1][0] = 1;
+      r_mat[0][1] = 1;
+      r_mat[1][1] = 0;
+      return;
+    }
     r_mat[0][1] = v0 / vn;
     r_mat[1][1] = v1 / vn;
   }

_______________________________________________
Bf-blender-cvs mailing list
Bf-blender-cvs@blender.org
https://lists.blender.org/mailman/listinfo/bf-blender-cvs