Commit: e4871b28350d0facfcfe86ca7e070ccb38d0e43b
Author: Pablo Vazquez
Date: Wed Nov 16 14:28:12 2022 +0100
Branches: master
https://developer.blender.org/rBe4871b28350d0facfcfe86ca7e070ccb38d0e43b
EEVEE/Viewport: Make info text when compiling shaders more clear
The N in `Compiling Shaders N` in Text Info, is the number of how many
shaders are left in the queue. It's a countdown, but this wasn't mentioned
and led to confusion.
Ideally this text would be like Cycles' "Samples 50/100", but in EEVEE it's
not easy to guess how many shaders are left (this number could even go
up mid-compilation).
In the past there used to be a progress bar but it's also confusing because
it could be 90/100 shaders done, but the remaining 10 are slow to compile.
Change the text to "Compiling Shaders (N remaining)" so it's easier to
understand what is going on. Similar to how some game engines do.
===================================================================
M source/blender/draw/engines/eevee/eevee_engine.c
M source/blender/draw/engines/eevee_next/eevee_instance.cc
===================================================================
diff --git a/source/blender/draw/engines/eevee/eevee_engine.c
b/source/blender/draw/engines/eevee/eevee_engine.c
index 5ae4b730cfa..ff17c02b3ee 100644
--- a/source/blender/draw/engines/eevee/eevee_engine.c
+++ b/source/blender/draw/engines/eevee/eevee_engine.c
@@ -174,7 +174,7 @@ static void eevee_cache_finish(void *vedata)
}
if (g_data->queued_shaders_count > 0) {
- SNPRINTF(ved->info, "Compiling Shaders %d", g_data->queued_shaders_count);
+ SNPRINTF(ved->info, "Compiling Shaders (%d remaining)",
g_data->queued_shaders_count);
}
}
diff --git a/source/blender/draw/engines/eevee_next/eevee_instance.cc
b/source/blender/draw/engines/eevee_next/eevee_instance.cc
index a0bdf70e254..744b1611f37 100644
--- a/source/blender/draw/engines/eevee_next/eevee_instance.cc
+++ b/source/blender/draw/engines/eevee_next/eevee_instance.cc
@@ -337,7 +337,7 @@ void Instance::draw_viewport(DefaultFramebufferList *dfbl)
if (materials.queued_shaders_count > 0) {
std::stringstream ss;
- ss << "Compiling Shaders " << materials.queued_shaders_count;
+ ss << "Compiling Shaders (" << materials.queued_shaders_count << "
remaining)";
info = ss.str();
}
}
_______________________________________________
Bf-blender-cvs mailing list
Bf-blender-cvs@blender.org
List details, subscription details or unsubscribe:
https://lists.blender.org/mailman/listinfo/bf-blender-cvs
