[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [42540] trunk/blender/source/blender/ editors/mesh/editmesh_mods.c: Fix #29558: Selecting similar edges doesn' t work

[Sergey Sharybin]

Revision: 42540
          
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=42540
Author:   nazgul
Date:     2011-12-09 16:10:15 +0000 (Fri, 09 Dec 2011)
Log Message:
-----------
Fix #29558: Selecting similar edges doesn't work

Return OPERATOR_FINISHED from select grouped operator in any case so
even if nothing were selected operator would be registered in redo panel
and threshold can be adjusted there.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/mesh/editmesh_mods.c

Modified: trunk/blender/source/blender/editors/mesh/editmesh_mods.c
===================================================================
--- trunk/blender/source/blender/editors/mesh/editmesh_mods.c   2011-12-09 
15:56:04 UTC (rev 42539)
+++ trunk/blender/source/blender/editors/mesh/editmesh_mods.c   2011-12-09 
16:10:15 UTC (rev 42540)
@@ -873,12 +873,10 @@
                /* here was an edge-mode only select flush case, has to be 
generalized */
                EM_selectmode_flush(em);
                WM_event_add_notifier(C, NC_GEOM|ND_SELECT, obedit->data);
-               BKE_mesh_end_editmesh(me, em);
-               return OPERATOR_FINISHED;
        }
        
        BKE_mesh_end_editmesh(me, em);
-       return OPERATOR_CANCELLED;
+       return OPERATOR_FINISHED;
 }      
 
 /* ***************************************************** */
@@ -1092,12 +1090,10 @@
                /* here was an edge-mode only select flush case, has to be 
generalized */
                EM_selectmode_flush(em);
                WM_event_add_notifier(C, NC_GEOM|ND_SELECT, obedit->data);
-               BKE_mesh_end_editmesh(me, em);
-               return OPERATOR_FINISHED;
        }
-       
+
        BKE_mesh_end_editmesh(me, em);
-       return OPERATOR_CANCELLED;
+       return OPERATOR_FINISHED;
 }
 
 /* ********************************* */
@@ -1135,7 +1131,7 @@
        
        if (!ok || !deselcount) { /* no data selected OR no more data to 
select*/
                BKE_mesh_end_editmesh(me, em);
-               return 0;
+               return OPERATOR_CANCELLED;
        }
        
        if(mode == SIMVERT_FACE) {
@@ -1230,12 +1226,10 @@
 
        if(selcount) {
                WM_event_add_notifier(C, NC_GEOM|ND_SELECT, obedit->data);
-               BKE_mesh_end_editmesh(me, em);
-               return OPERATOR_FINISHED;
        }
 
        BKE_mesh_end_editmesh(me, em);
-       return OPERATOR_CANCELLED;
+       return OPERATOR_FINISHED;
 }
 
 static int select_similar_exec(bContext *C, wmOperator *op)

_______________________________________________
Bf-blender-cvs mailing list
Bf-blender-cvs@blender.org
http://lists.blender.org/mailman/listinfo/bf-blender-cvs