Commit: c16a98bb068b93a5f111078480236bdf027ebd1d
Author: Bastien Montagne
Date:   Sun Aug 27 12:20:21 2017 +0200
Branches: blender2.8
https://developer.blender.org/rBc16a98bb068b93a5f111078480236bdf027ebd1d

Fix T52498: Deleting force field doesn't remove "Surface" from modifier stack.

Logic in `ED_object_check_force_modifiers` was inconsistent between add
and remove modifier cases.

Should be safe enough for 2.79.

===================================================================

M       source/blender/editors/object/object_edit.c

===================================================================

diff --git a/source/blender/editors/object/object_edit.c 
b/source/blender/editors/object/object_edit.c
index d9d81cbc1fd..289d0bb586b 100644
--- a/source/blender/editors/object/object_edit.c
+++ b/source/blender/editors/object/object_edit.c
@@ -976,13 +976,16 @@ void ED_object_check_force_modifiers(Main *bmain, Scene 
*scene, Object *object)
 
        /* add/remove modifier as needed */
        if (!md) {
-               if (pd && (pd->shape == PFIELD_SHAPE_SURFACE) && 
ELEM(pd->forcefield, PFIELD_GUIDE, PFIELD_TEXTURE) == 0)
-                       if (ELEM(object->type, OB_MESH, OB_SURF, OB_FONT, 
OB_CURVE))
+               if (pd && (pd->shape == PFIELD_SHAPE_SURFACE) && 
!ELEM(pd->forcefield, 0, PFIELD_GUIDE, PFIELD_TEXTURE)) {
+                       if (ELEM(object->type, OB_MESH, OB_SURF, OB_FONT, 
OB_CURVE)) {
                                ED_object_modifier_add(NULL, bmain, scene, 
object, NULL, eModifierType_Surface);
+                       }
+               }
        }
        else {
-               if (!pd || pd->shape != PFIELD_SHAPE_SURFACE || pd->forcefield 
!= PFIELD_FORCE)
+               if (!pd || (pd->shape != PFIELD_SHAPE_SURFACE) || 
ELEM(pd->forcefield, 0, PFIELD_GUIDE, PFIELD_TEXTURE)) {
                        ED_object_modifier_remove(NULL, bmain, object, md);
+               }
        }
 }

_______________________________________________
Bf-blender-cvs mailing list
[email protected]
https://lists.blender.org/mailman/listinfo/bf-blender-cvs

Reply via email to