When using CLangs static checker on Blender, there are a large number of 'dead stores' - variables that are assigned a value, but the variable is never used.
Thus these are items that either had functionality at one point, but no longer do. Or are intended to have functionality that is not yet in use. Almost none of them are commented so it isn't readily determined which of the two cases it is. There are about 200 instances of dead stores in the code. Here are some examples (filename, then variable name, and the line number). In my view they should either be commented, commented out or deleted. Having them in the code can make it confusing to read since you try and track where and how the variable is used. anim_channel_defines.c type - 2614 ok (unneeded ++) enabled - 3121 text - 3241 offset - 3266, 3271 anim_channels_edit.c prevLevel - 490 ymin - 1766, 1770 fmodifier_ui.c col - 117 row - 523, 541 keyframes_draw.c abp - 363 drawgpencil.c actlay - 540 gpencil_paint.c ok - 1356 interface.c okwidth - 2087 str - 2193 interface_handlers.c retval - 1798 softmin - 2237 softmax - 2238 temp - 2399 screen_my - 2424 click - 2786 offsx - 2380 offsy - 2381 changed - 3480, 3511 dx - 3603, 3686 yfac - 3695 _______________________________________________ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers