Hi, Ton! I'm afraid this commit broke to much things.
- After some changes to render settings/node tree render result could be incorrect (black textures) - Sculpt mode with texture is unworkable after undo - Fixed Texture isn't workable First two things are quite easy to be fixed, but i have no idea how to handle "Fixed Texture" for image piting and "Tiled" for sculpting. Idea of initializing image when stroke begins wouldn't work well from artists point of view. As i showed you in IRC texture could be procedural and when it's sized to brush radius it could have noticable boundary between different tiles, but if it'll be re-calculated for needed relative coord (from initial brush pos) it'll be continious. You could compare http://www.pasteall.org/pic/9577 and http://www.pasteall.org/pic/9578 (first image is made with texture image created form node at initial step, second one - with re-calculation on-demand (how it's implemented atm)). In both cases i've used "Magic" texture node. Not sure if it's really bad. If not -- i've already got fix for paiting mode and could make changes to sculpting mode. If not -- we should create something smarter. And i'm not 100% sure what's happening with this ntreeBeginExecTree/ntreeEndExecTree. I've tried to add this near texture recalculation in fixed texture brush handler and it worked fine (but really slow). But why it's not affected with threading issues? I mean what would happen if preview widget would be triggered to redraw between my ntreeBeginExecTree/ .. ntreeEndExecTree block? Wouldn't it also lead to wrong texture recalculation? And if it've got copy of node tree why this BeginExec/EndExec is necessery? And i'm also afraid of preview refresh triggering between ntreeBeginExecTree() and actual image generating from texture. One more thing, suclpting uses openmp threads and texture re-calculation in them. looks like this also wouldn;t work correct. P.S. I'm afraid i'll be online only after ~12 a-dam time, so trunk could be a bit unusable in this areas until this time. -------- Original Message -------- Subject: [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [35338] trunk/blender/source/blender: bugfix #26267 From: Ton Roosendaal <t...@blender.org> To: bf-blender-...@blender.org Date: 03/03/2011 11:53 PM > Revision: 35338 > > http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=35338 > Author: ton > Date: 2011-03-03 18:53:07 +0000 (Thu, 03 Mar 2011) > Log Message: > ----------- > bugfix #26267 > > ImageWindow + 3D view texture paint + texture preview render + texture nodes. > Threading hell! But it works now :) > > Modified Paths: > -------------- > trunk/blender/source/blender/blenkernel/BKE_texture.h > trunk/blender/source/blender/blenkernel/intern/node.c > trunk/blender/source/blender/blenkernel/intern/texture.c > trunk/blender/source/blender/editors/render/render_preview.c > trunk/blender/source/blender/editors/sculpt_paint/paint_image.c > ... -- With best regards, Sergey I. Sharybin _______________________________________________ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers