It should still confirm on simple click without release_confirm on,
though.  The two are separate features; one releases on mouse up in
edge slide itself, while the other allows you to quickly add loopcuts
without having to cancel out of edgeslide every time (but you might
not want release_confirm on).

Still, the patch is certainly a lot simpler and less intrusive.  If I
keep the OPERATOR_ABORT_MACRO flag, I can probably get rid of the
timer and launch_event thing (and of course that extraneous user pref)
and do everything in loopcut.  How's that?

Joe

On Wed, May 4, 2011 at 11:17 AM, Campbell Barton <ideasma...@gmail.com> wrote:
> Heres a patch on r36449 (before this commit) which uses existing
> transform release preference and from what I can tell works ok. (no
> timer, no new preferences, no macro abort option).
>
> Patch:
> http://www.graphicall.org/ftp/ideasman42/click_release_loopcut_36449.py
>
> If its acceptable Ill add an RNA function RNA_property_unset() and do
> the ID property adjustment there.
>
> Joe, Martin - what do you think?
>
> On Tue, May 3, 2011 at 6:50 PM, joe <joe...@gmail.com> wrote:
>> On Mon, May 2, 2011 at 9:24 PM, Martin Poirier <the...@yahoo.com> wrote:
>>>
>>> Yes and I happen to think I know those parts of the code (macro, transform) 
>>> as well if not better than you do.
>>
>> :P
>>
>>>
>>> This isn't a nice way at all to solve this problem.
>>>
>>
>> I saw the nasty hack for manipulators, which  lead me to think I *was*
>> doing a "nice" solution, short of rewriting the entire release_confirm
>> functionality.
>>
>>> Martin
>>> _______________________________________________
>>
>> Joe
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers@blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
>>
>
>
>
> --
> - Campbell
> _______________________________________________
> Bf-committers mailing list
> Bf-committers@blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>
_______________________________________________
Bf-committers mailing list
Bf-committers@blender.org
http://lists.blender.org/mailman/listinfo/bf-committers

Reply via email to