In r60726, I corrected a remaining WITH_IMAGE_OPENIMAGEIO. You forgot to modify it.
IRIE Shinsuke 13/10/13, Dalai Felinto wrote: > I actually think we should have WITH_OPENIMAGEIO instead of > WITH_IMAGE_OPENIMAGEIO. > > It's how it was already in CMakeLists.txt and there is no big compelling > argument to change that. > > I committed the fix in rev.60718 [to get PSD working by default - even if > WITH_OPENIMAGEIO is OFF, assuming WITH_CYCLES is ON] > > Cheers, > Dalai > > -- > blendernetwork.org/dalai-felinto > www.dalaifelinto.com > > > 2013/10/12 IRIE Shinsuke <irieshins...@yahoo.co.jp> > >> Got it, but I think the CMake variable WITH_OPENIMAGEIO is not needed. >> It should be replaced with WITH_IMAGE_OPENIMAGEIO, and Cycles should >> simply depend on WITH_IMAGE_OPENIMAGEIO like this: >> >> >> # auto enable openimageio for cycles >> if(WITH_CYCLES) >> set(WITH_IMAGE_OPENIMAGEIO ON) >> endif() >> >> # auto enable openimageio linking dependencies >> if(WITH_IMAGE_OPENIMAGEIO) >> set(WITH_IMAGE_OPENEXR ON) >> set(WITH_IMAGE_TIFF ON) >> endif() >> >> >> IRIE Shinsuke >> >> 13/10/12, Dalai Felinto wrote: >>> Hi, >>> >>>> it causes unwanted behavior that the PSD support is enabled even if >>> WITH_IMAGE_OPENIMAGEIO=OFF and WITH_CYCLES=ON >>> >>> This is actually the wanted behaviour. Bear with me ... >>> >>> If the average user just builds Blender, she gets Cycles, PSD, all the >>> goodies. >>> >>> If the advanced user/developer doesn't want to build Cycles but wants PSD >>> support, she does WITH_CYCLES=OFF and WITH_IMAGE_OPENIMAGEIO=ON >>> >>> If the user doesn't want anything to use OIIO, she simply does >>> WITH_CYCLES=OFF. >>> >>> I believe (may be wrong) that one of main ideas of having those defines >> in >>> the code is to speed up building (less code to build, less libraries to >>> link to ...). Thus I think we should tie the defines to the library, not >>> the feature. >>> >>> Dalai // mobile >>> _______________________________________________ >>> Bf-committers mailing list >>> Bf-committers@blender.org >>> http://lists.blender.org/mailman/listinfo/bf-committers >>> >> _______________________________________________ >> Bf-committers mailing list >> Bf-committers@blender.org >> http://lists.blender.org/mailman/listinfo/bf-committers >> > _______________________________________________ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers > _______________________________________________ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers