On Tue, Nov 26, 2013 at 10:37 PM, Julien RIVAUD (_FrnchFrgg_) < frnchf...@free.fr> wrote:
> Le 26/11/2013 15:30, Sergey Sharybin a écrit : > >> Maybe with a system that let commits pass through if they are > Signed-Of-By any of {Brecht, Campbell, Sergey, Ton} ? (Same for merge > >> commits and almost any other enforced rule) > > Wouldn't work. Because it was Campbell's commits which used to break the > > whole repository because he had un-pushed local commit to addons and was > > kept doing `git commit .` from the repository root. > > > > So basically i wouldn't trust this Signed-Of-By because accidents > happens. > Sorry, I meant Acked-By or Reviewed-By, or whatever tag Phabricator uses > to indicate that the change was properly reviewed (by at least 2 > people). Such changes would be uncommon anyway and for a release that's > good if the review is thorough. > Crap could happen after the review when using `arc land` to push reviewed patch. > > Yes, totally temporary. I'm in contact with git devs and they really > wants > > this to be fixed. > > > > I was just totally annoyed today because like every single night repo > > became broke and buildbot failed to pull the changes and everyone who > tried > > to clone the repo had issues as well. > > > > For until every developer uses fixed version of git, i would rather use > > some sanity-check hooks to help preventing accidents. > Of course you're right. But you cannot force people to use these hooks, > nor expect that all install them correctly (with the executable bit on, > etc...); that's why server hooks are safer. > I know. The intention was to share sanity check hooks with those who wants to use them. -- With best regards, Sergey Sharybin _______________________________________________ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers