Hi, No stepping toes here. Branches should just always work, especially the ones more people work on together. It's a good habit to never commit code that breaks things. And if that's inevitable, align the other coders to help fixing it with highest priority. Or ifdef things out.
Luca: so, if yo notice someone committing code that breaks things, just notify the person immediate. He/she is not meant to do this without general approval. Laters, -Ton- -------------------------------------------------------- Ton Roosendaal - [email protected] - www.blender.org Chairman Blender Foundation, Director Blender Institute Entrepotdok 57A, 1018 AD, Amsterdam, the Netherlands > On 23 Feb 2017, at 07:58, Luca Rood <[email protected]> wrote: > > Hey, > > I don't mean to cross any lines here, but I feel that this is important to be > said. > > As far as I'm aware, the blender2.8 branch is supposed to replace master > eventually, and much of the development has moved there already. > Also, the word seems to be to keep blender2.8 stable, within reason. > > With that in mind, it seems logical to take just as much care of blender2.8 > as master. This is one of our main development branches, and shouldn't be > treated as lightly as one's personal branch or such. > > Despite that, and especially with the OpenGL immediate mode work going on, we > continue getting commits that break Blender because of simple negligence. > For instance, often the UI gets mangled, or we even get segfaults because of > simple OpenGL mistakes, that could easily be avoided if the code was actually > tested at all. > > I think everyone would appreciate it if we all tested our code before pushing > it, to avoid at least the most obvious mistakes (a successful build does not > always mean that stuff actually works :P ). > So this is just a reminder for everyone to please test stuff before > submitting (at least a little bit...) > > Again, I mean this just as a friendly observation :) > If I'm wrong about my interpretation of the purpose of the blender2.8 branch, > please let me know. > > Happy coding, > > Luca > > _______________________________________________ > Bf-committers mailing list > [email protected] > https://lists.blender.org/mailman/listinfo/bf-committers _______________________________________________ Bf-committers mailing list [email protected] https://lists.blender.org/mailman/listinfo/bf-committers
