On 7/25/2017 3:38 AM, Sergey Sharybin wrote: > >> I would like to have the files in the main Blender repo so that when adding >> or upgrading a library, a single commit documents all the changes, and can >> be submitted to differential. It also means we can reuse existing cmake >> code, which is more painful if we use a submodule. >> > I don't see why submitting a patch to differencial is important. It is much > more important to mail this mailing list when you need something. This is > the only reliable way to guarantee all platform maintainers and maintainers > of our build instructions on Wiki will pick things up and sign under that > they made a build.
I don't think we're gonna have a single commit for a lib upgrade anyhow, there's a bunch of externals that do not test on windows regularly , (oiio had it's fair share of issues in the last year for instance) if someone updates a lib version, odds are i have to make some patches to actually make it build. That being said, I'd still prefer doing that than all platform devs having their own build scripts to maintain. --Ray _______________________________________________ Bf-committers mailing list Bf-committers@blender.org https://lists.blender.org/mailman/listinfo/bf-committers
