Hi Troy, > https://developer.blender.org/differential/diff/9682/
Could you submit the patch with `arc diff` instead? I have a few points to make to the patch, and I would like to try it. For instance: 1. Did you make sure Blender treat this texture as a "non-color" texture for my_texture_linear.tiff? 2. You seem to be handling linear and srgb only. However you mentioned acescg here as well which doesn't seem to be handled. 3. Code-style: Basically follow: https://wiki.blender.org/index.php/Dev:Doc/Code_Style * use `if (` instead of `if(` * use explicit {} * configParseColorSpaceFromString seems to have way to many left spaces before the filename. Thanks, Dalai _______________________________________________ Bf-committers mailing list [email protected] https://lists.blender.org/mailman/listinfo/bf-committers
