You can submit the code for review here: https://developer.blender.org/differential/diff/create/
On Mon, Mar 11, 2019 at 7:06 PM Benjamin Schmithüsen <schmithue...@ux3d.io> wrote: > Hi Brecht, > > thanks for the quick reply! I will update our setup following your > instructions. When that's done, how would we get it into Blender? > > Regards > Benjamin > > On 3/11/19 5:18 PM, Brecht Van Lommel wrote: > > Hi Benjamin, > > > > It would be better to copy the source code to extern/ as we do for some > > other libraries, rather than referring to a git submodule we do host or > > control ourselves. The Google Draco repository is also quite big due to > > including compiled binaries, the part we actually need is much smaller. > > > > If possible it would also be best to make a simple custom CMakeLists.txt > to > > compile Draco, so it can use all the same compiler configuration and > flags > > as used by the rest of Blender. > > > > For installation I think /2.80/python/lib/python3.7/site-packages may be > > best, where additional libraries like numpy are installed. > > > > Regards, > > Brecht. > > > > > > On Mon, Mar 11, 2019 at 4:52 PM Benjamin Schmithüsen < > schmithue...@ux3d.io> > > wrote: > > > >> Hi, > >> > >> thanks for the pointers! With them, I believe I found a solution: The > >> only change in the Blender repository would be adding a git submodule to > >> the extern folder and updating the CMakeLists.txt to add that as a > >> subdirectory like you described. That submodule in turn contains the > >> original Google draco repository as a submodule to be able to compile > >> our blender-draco-compressor library that is then stored in > >> /2.80/python/lib/python3.7/ with the Blender binary. I chose that > >> location because it is a library that we directly call from our Python > >> code in the io_scene_gltf2 addon (not through bpy). > >> > >> Does this sound reasonable so far? > >> > >> Best regards > >> Benjamin > >> > >> On 2/27/19 6:53 PM, Brecht Van Lommel wrote: > >>> Hi, > >>> > >>> There isn't really any documentation on this, best would be to copy > what > >> is > >>> done for a library like extern/ceres or Python module like numpy that > we > >>> bundle. So far we have not bundled extra Python modules with Blender in > >>> exactly this way though, so there is no identical example. > >>> > >>> I think you would start by coping that google-draco-exporter folder to > >>> extern/draco. Then add a WITH_DRACO option and if that's enabled add > that > >>> subdirectory in extern/CMakeListsts.txt. > >>> > >>> Installing the Python module to the right directory would be done in > >>> source/creator/CMakeLists.txt. > >>> > >>> Regards, > >>> Brecht. > >>> > >>> On Tue, Feb 26, 2019 at 5:47 PM Benjamin Schmithüsen < > >> schmithue...@ux3d.io> > >>> wrote: > >>> > >>>> Hi Brecht, > >>>> > >>>> is there any documentation available on how to correctly setup a new > >>>> project in the extern/ folder so it can be included by Blender and > >>>> exposed through bpy? > >>>> > >>>> Best regards > >>>> Benjamin > >>>> > >>>> _______________________________________________ > >>>> Bf-committers mailing list > >>>> Bf-committers@blender.org > >>>> https://lists.blender.org/mailman/listinfo/bf-committers > >>>> > >>> _______________________________________________ > >>> Bf-committers mailing list > >>> Bf-committers@blender.org > >>> https://lists.blender.org/mailman/listinfo/bf-committers > >> -- > >> > >> *UX3D GmbH* > >> GPU Software Solutions > >> > >> Benjamin Schmithüsen > >> GPU Software Engineer > >> Neumarkter Str. 21 > >> 81673 Munich, Germany > >> > >> T: +49 (0)89 215 44 258 4 > >> F: +49 (0)89 215 44 258 8 > >> schmithue...@ux3d.io <mailto:schmithue...@ux3d.io> > >> www.ux3d.io > >> > >> _______________________________________________ > >> Bf-committers mailing list > >> Bf-committers@blender.org > >> https://lists.blender.org/mailman/listinfo/bf-committers > >> > > _______________________________________________ > > Bf-committers mailing list > > Bf-committers@blender.org > > https://lists.blender.org/mailman/listinfo/bf-committers > -- > > *UX3D GmbH* > GPU Software Solutions > > Benjamin Schmithüsen > GPU Software Engineer > Neumarkter Str. 21 > 81673 Munich, Germany > > T: +49 (0)89 215 44 258 4 > F: +49 (0)89 215 44 258 8 > schmithue...@ux3d.io <mailto:schmithue...@ux3d.io> > www.ux3d.io > > _______________________________________________ > Bf-committers mailing list > Bf-committers@blender.org > https://lists.blender.org/mailman/listinfo/bf-committers > _______________________________________________ Bf-committers mailing list Bf-committers@blender.org https://lists.blender.org/mailman/listinfo/bf-committers