Fun fact, Geoffry designed the mempool library out of a desire to get something that was more like the Mesh structure. Anyway, I'm not terribly wedded to a dedicated trimesh library (it's very basic code with an API based off BMesh). The important non-trimesh-related changes seem to be:
1. Don't set pbvh->leaf_limit too low. 2. Change active sculpt vertex "index" from an int to a generic intptr_t. That drastically cuts down the usage of BMesh element tables, which is a huge performance boost. 3. Attach pointer arrays to PBVHNode->bm_unique_verts, bm_other_verts, to avoid iterating over GHashes. Alternatively, inline the GHash iterators. 4. Support dynamically joining PBVH nodes. 5. Don't use BMLog to cache original vertex/normal data. On Fri, Oct 16, 2020 at 9:33 AM Brecht Van Lommel via Bf-committers < [email protected]> wrote: > It's not clear to me that being triangle based only is a good thing about > dynamic topology. It would be better if it preserved ngons and only > triangulated parts of the mesh where actual changes are being made. And > also did not lose vertex colors and UV maps. > > Maybe it's possible to use MVert and MPoly, and find a way to dynamically > grow/shrink the arrays? Then there would be one less special case in the > sculpt code. > > On Wed, Oct 14, 2020 at 10:55 PM Joe Eagar via Bf-committers < > [email protected]> wrote: > > > I’ve actually copied the existing DynTopo code for a base, but with a > > triangle mesh lib (with a BMesh like API) instead of BMesh. I’m modifying > > it from there, design is contingent on further profiling (for example, > I’m > > not sure we’ll end up needing the topology update to be multithreaded, so > > far most performance bugs have been cache related). > > > > > > > > On Wed, Oct 14, 2020 at 9:12 AM Dalai Felinto <[email protected]> wrote: > > > > > Hi Joe, > > > > > > By the way, could you please put together a design document before you > > > go on with the branch development? This way we can get the design > > > cleared out before you spend your time coding it. > > > > > > Thank you, > > > -Dalai- > > > -------------------------------------------------------------------- > > > Dalai Felinto - [email protected] - www.blender.org > > > Blender Development Coordinator > > > Buikslotermeerplein 161, 1025 ET Amsterdam, the Netherlands > > > < > > > https://www.google.com/maps/search/Buikslotermeerplein+161,+1025+ET+Amsterdam,+the+Netherlands?entry=gmail&source=g > > > > > > > > > Em qua., 14 de out. de 2020 às 15:11, Dalai Felinto > > > <[email protected]> escreveu: > > > > > > > > Hi Joe, > > > > > > > > It is worth taking a look at this refresh course: > > > > https://wiki.blender.org/wiki/Developer_Intro/Committer > > > > > > > > It goes over format style, branches, test builds, ... > > > > > > > > And welcome back :) > > > > -Dalai- > > > > -------------------------------------------------------------------- > > > > Dalai Felinto - [email protected] - www.blender.org > > > > Blender Development Coordinator > > > > Buikslotermeerplein 161, 1025 ET Amsterdam, the Netherlands > > > > > > > > Em qua., 14 de out. de 2020 às 04:10, Joe Eagar via Bf-committers > > > > <[email protected]> escreveu: > > > > > > > > > > Thanks, I got it to work. I was just confused. > > > > > > > > > > On Tue, Oct 13, 2020 at 6:11 PM Julian Eisel via Bf-committers < > > > > > [email protected]> wrote: > > > > > > > > > > > Hey, > > > > > > > > > > > > People who had commit rights with SVN still have in the Git > > > repository. So > > > > > > you should already/still have them. > > > > > > Nowadays, giving commit rights means adding someone as member to > > the > > > BF > > > > > > Blender project on developer.blender.org < > > > http://developer.blender.org/> > > > > > > -- which you are: > > > > > > > > > > > > https://developer.blender.org/project/?member=PHID-USER-dh5md27jh3dxb57kokls > > > > > > < > > > > > > > > > > > > https://developer.blender.org/project/?member=PHID-USER-dh5md27jh3dxb57kokls > > > > > > >. > > > > > > > > > > > > Cheers, > > > > > > - Julian - > > > > > > > > > > > > > > > ---------------------------------------------------------------------- > > > > > > Julian Eisel - [email protected] - www.blender.org > > > > > > Software Developer > > > > > > > > > > > > > On 14. Oct 2020, at 01:25, Joe Eagar via Bf-committers < > > > > > > [email protected]> wrote: > > > > > > > > > > > > > > > > > > > > > Hi. I've been working on the DynTopo code a bit and I'd like a > > > branch to > > > > > > > commit my work. Can I get whatever account permissions are > > needed > > > for > > > > > > > this? I promise I won't commit to master. :P > > > > > > > > > > > > > > Best, > > > > > > > Joe Eagar > > > > > > > _______________________________________________ > > > > > > > Bf-committers mailing list > > > > > > > [email protected] > > > > > > > https://lists.blender.org/mailman/listinfo/bf-committers > > > > > > > > > > > > _______________________________________________ > > > > > > Bf-committers mailing list > > > > > > [email protected] > > > > > > https://lists.blender.org/mailman/listinfo/bf-committers > > > > > > > > > > > _______________________________________________ > > > > > Bf-committers mailing list > > > > > [email protected] > > > > > https://lists.blender.org/mailman/listinfo/bf-committers > > > > > _______________________________________________ > > Bf-committers mailing list > > [email protected] > > https://lists.blender.org/mailman/listinfo/bf-committers > > > _______________________________________________ > Bf-committers mailing list > [email protected] > https://lists.blender.org/mailman/listinfo/bf-committers > _______________________________________________ Bf-committers mailing list [email protected] https://lists.blender.org/mailman/listinfo/bf-committers
