Revision: 26420
          http://sourceforge.net/p/bibdesk/svn/26420
Author:   hofman
Date:     2021-07-15 16:19:03 +0000 (Thu, 15 Jul 2021)
Log Message:
-----------
Return width rather than updating by reference

Modified Paths:
--------------
    trunk/bibdesk/BDSKEditor.m

Modified: trunk/bibdesk/BDSKEditor.m
===================================================================
--- trunk/bibdesk/BDSKEditor.m  2021-07-15 16:16:43 UTC (rev 26419)
+++ trunk/bibdesk/BDSKEditor.m  2021-07-15 16:19:03 UTC (rev 26420)
@@ -3459,7 +3459,7 @@
        editorFlags.didSetupFields = YES;
 }
 
-- (void)addButtonToCollectionviewItem:(BDSKEditorCollectionViewItem *)item 
maxWidth:(CGFloat *)maxWidth {
+- (CGFloat)addButtonToCollectionviewItem:(BDSKEditorCollectionViewItem *)item {
     NSString *field = [item representedObject];
     NSView *view = [item view];
     NSButton *button = nil;
@@ -3491,7 +3491,7 @@
     [item setButton:button];
     [button release];
     
-    *maxWidth = fmax(*maxWidth, [view fittingSize].width);
+    return [view fittingSize].width;
 }
 
 - (void)setupCollectionView {
@@ -3508,7 +3508,7 @@
     CGFloat width = 0.0;
     
     for (i = 0; i < iMax; i++)
-        [self addButtonToCollectionviewItem:(BDSKEditorCollectionViewItem 
*)[collectionView itemAtIndex:i] maxWidth:&width];
+        width = fmax(width, [self 
addButtonToCollectionviewItem:(BDSKEditorCollectionViewItem *)[collectionView 
itemAtIndex:i]]);
     
     NSSize size = NSMakeSize(width, 22.0);
     [collectionView setMinItemSize:size];

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
Bibdesk-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to